search

michaelwiles / google-gin

Automatically exported from code.google.com/p/google-gin
Apache License 2.0
0 stars 0 forks source link

AssistedInject fails for parameterized factories #108

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Errors occur when binding parameterized factories in Gin's assisted inject
using a construct like this:

install(new GinFactoryModuleBuilder()
    .build(new TypeLiteral<MyFactory<String>>(){});

A similar issue occurred in Guice:
http://code.google.com/p/google-guice/issues/detail?id=478

A patch that fixes this issue has been submitted here:
http://codereview.appspot.com/1333041

Please review!

Original issue reported on code.google.com by aragos on 26 May 2010 at 8:24

GoogleCodeExporter commented 9 years ago 
Fixed in r143.

Original comment by aragos on 8 Jul 2010 at 10:27

GoogleCodeExporter commented 9 years ago 
Turns out that this fix wasn't complete, some method type parameters are not 
correctly inherited. Testing and writing a fix now.

Original comment by aragos on 22 Jul 2010 at 3:59

GoogleCodeExporter commented 9 years ago 
New fix for review: http://codereview.appspot.com/1870043

Original comment by aragos on 22 Jul 2010 at 4:21

GoogleCodeExporter commented 9 years ago 
Fixed in r146.

Original comment by aragos on 10 Aug 2010 at 1:58