Inherited ginjectors can cause module clashes

michaelwiles / google-gin

Automatically exported from code.google.com/p/google-gin

Apache License 2.0

0 stars 0 forks source link

Inherited ginjectors can cause module clashes #112

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

By using inheriting ginjectors, an application can cause the same module to be 
used twice (or more) in the same ginjector generation. This usually causes 
binding conflicts. Guice only uses each module once (even if it was requested 
multiple times), Gin should do the same.

Original issue reported on code.google.com by aragos on 9 Jul 2010 at 12:21

GoogleCodeExporter commented 9 years ago

Submitted for review: http://codereview.appspot.com/1780041

Original comment by aragos on 9 Jul 2010 at 12:22

Changed state: Review

GoogleCodeExporter commented 9 years ago

Fixed in r144.

Original comment by aragos on 9 Jul 2010 at 3:09

Changed state: Fixed