michaelwiles / google-gin

Automatically exported from code.google.com/p/google-gin
Apache License 2.0
0 stars 0 forks source link

Build does not work when parent directories have spaces (Windows XP) #50

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
After checking out GIN, to my eclipse workspace, I run the build.xml script
and get the output in the attached file. The path to the project has spaces
in it and it appears that it is being incorrectly tokenized.

The build works fine when I move it to a different location (without
spaces). I am using Windows XP, Eclipse 3.4 and GWT 1.7.

Original issue reported on code.google.com by Tin.Pavl...@gmail.com on 22 Jul 2009 at 4:11

Attachments:

GoogleCodeExporter commented 9 years ago
I spent some time looking into this but the solution is more complicated than I
thought. Basically, we need to try to escape the paths passed as part of a 
jvmarg to
the junit tests. That is also possible, by replacing lin 168 of our current 
build
file (r110) with this one:

<jvmarg value='-Dgwt.args=@{extragwtargs} -gen """@{outputbase}/gen""" -out
"""@{outputbase}/out"""'/>

However, that doesn't solve the whole problem - unfortunately we try to load 
some
jave sources inside a test and the file loader there has problems with the 
escaped
spaces.

But the real problem is that while the above line escapes the paths properly in
Windows, it breaks the ant script in all other systems. Unfortunately I could 
find no
simple way to replace the jvmarg parameter based on the current operation 
system in ant.

For now I suggest that those who run into this issue just use a path without 
spaces
in it when operating under Windows.

Original comment by aragos on 27 Aug 2009 at 10:09

GoogleCodeExporter commented 9 years ago

Original comment by aragos on 1 Sep 2009 at 5:33

GoogleCodeExporter commented 9 years ago
Fix sent for review: http://codereview.appspot.com/126056

Original comment by t.broyer on 30 Sep 2009 at 9:17

GoogleCodeExporter commented 9 years ago
Thanks to t.broyer, fix submitted in r116.

Original comment by aragos on 1 Oct 2009 at 3:48