michaelwillis / dragonfly-reverb

A set of free reverb effects
https://michaelwillis.github.io/dragonfly-reverb
GNU General Public License v3.0
920 stars 70 forks source link

3.2.8: CLAP: Wrong rendering in Reaper #151

Open koalastudio72 opened 1 year ago

koalastudio72 commented 1 year ago

Hi, I have the issue that the CLAP-Version in 3.2.8 doesn't fit in the plugin window in Reaper 6.73 (WIN-Version).

Screenshot: 2023-01-01_15-28

Thank you.

falkTX commented 1 year ago

what is your display scale factor? seems to be different than 100%

koalastudio72 commented 1 year ago

Thanks for the quick reply.

My scale factor: 125% But the VST2/VST3 versions fit well with this scale factor. When I switch to 100% all the text is unfortunately too small on a 15 inch laptop display. Any idea ?

falkTX commented 1 year ago

Might be a bug in reaper since the other versions work correctly. Do you have any other host installed that can also load clap in order to verify this? Bitwig or MultitrackStudio

koalastudio72 commented 1 year ago

Unfortunately not. Certainly I can live with the other versions and wait until the CLAP-versions work correct in Reaper. Nevertheless thank you for you support.

biopsin commented 1 year ago

Same thing happens for LV2 too

falkTX commented 1 year ago

I think I know why, but no time to investigate it proper at the moment.

trebmuh commented 1 year ago

https://forum.cockos.com/showthread.php?t=274388

pawelulita commented 9 months ago

I can reproduce it on Linux with Reaper, but not with Bitwig. Applying this patch to DPF makes the plugin size correct in Reaper and doesn't affect it in Bitwig. However, I have no idea if this is just a hack that fixes the problem for this plugin, or if this is (part of) a proper fix for a bug in DPF.

diff --git a/distrho/src/DistrhoPluginCLAP.cpp b/distrho/src/DistrhoPluginCLAP.cpp
index 29a0316d..0ad05ccd 100644
--- a/distrho/src/DistrhoPluginCLAP.cpp
+++ b/distrho/src/DistrhoPluginCLAP.cpp
@@ -297,6 +297,9 @@ public:
        #ifdef DISTRHO_OS_MAC
         *width /= scaleFactor;
         *height /= scaleFactor;
+       #else
+        *width *= scaleFactor;
+        *height *= scaleFactor;
        #endif

         return true;