search

michaelwittig / node-q

Q interfacing with Node.js
MIT License
52 stars 14 forks source link

Fix listen to handle #28

Closed emilebres closed 7 years ago

emilebres commented 7 years ago

Sorry, I was not careful when I made the pull request earlier and forgot to add some code. Here is the correct version. To apologize, I also fixed two typos in the README.

michaelwittig commented 7 years ago

hi @emilebres di you have a running q environment where you can test the code? If so, could you please add a integration test in the itest directory to make sure that the functionality works as expected?

emilebres commented 7 years ago

Like this?

michaelwittig commented 7 years ago

perfekt! I run those integration tests in itest before I npm publish so I can ensure that everything still works :) tests in test run automatically when you open a PR.

released as node-q@2.2.1