search

michaelwittig / node-q

Q interfacing with Node.js
MIT License
52 stars 14 forks source link

Add typescript declaration files. #33

Closed amirburbea closed 7 years ago

amirburbea commented 7 years ago

Add index.d.ts and lib/typed.d.ts Specify types in package.json Made typescript, as well as types for node & long, all devDependencies.

michaelwittig commented 7 years ago

thanks @amirburbea ! released as version 2.4.0

amirburbea commented 7 years ago

Thanks again, I was debating just making an @types/node-q package but figured this was more helpful to developers who might want it and not too much noise for those that don't

amirburbea commented 7 years ago

Actually, I don't need this use case but just realized my type declarations won't allow a user to just listen on a handle using k as in your example in the README.md.

class Connection need an overload of k that just takes a parameter of type callback. I'm at work so I can't do this now, but I suppose I can do it when I get home. You could just npm version patch to make it 2.4.1 when that's done