search

michaelwoods / onstar2mqtt

OnStarJS wrapper for MQTT
MIT License
106 stars 38 forks source link

Tire pressures are being converted incorrectly #269

Closed jerry-knight closed 1 year ago

jerry-knight commented 1 year ago

I think sometime recently the reported tire pressures in PSI are now showing values that are actually in kPa. All of my PSI values in homeassistant/sensor/[VIN]/tire_pressure/state are now in the ~260 range, and 260 kPA is about 38 PSI. The standard non-PSI values are in the ~1800 range, so it really seems like all of the pressure values are getting an extra PSI-to-kPA conversion.

I don't see any open issues in OnstarJS, so I'm not sure whether I should submit this here or there. I see some unit conversions in the onstar2mqtt source, but it could be that OnstarJS is reporting the wrong units.

I'm currently running the latest docker image that reports version 1.5.5 in the logs.

BigThunderSR commented 1 year ago

I'm getting wonky values for the tire pressures since last night and it is the same issue even when using OnStarJS directly without OnStar2MQTT.

jerry-knight commented 1 year ago

Submitted a corresponding issue to OnStarJS.

OnStarJS Issue #219

For now, I'm doing additional conversions to compensate.

BigThunderSR commented 1 year ago

It's not a direct kPa conversion either. They (GM) seem to have discombobulated the tire pressure outputs from the car on purpose to drive us nuts. 👎

BigThunderSR commented 1 year ago

I put a fix into my latest build at https://github.com/BigThunderSR/onstar2mqtt for now.

If the change stays persistent from OnStar over the next week, I'll submit a PR here for the same fix,

BigThunderSR commented 1 year ago

Looks like GM fixed the issue on their side, so I reverted the changes in my build.

On the flip side, I figured out a solution for https://github.com/michaelwoods/onstar2mqtt/issues/178 while staring at the code to implement the previous workaround, so it wasn't a complete waste. 😄

michaelwoods commented 1 year ago

Noticed this too, but looks to be back to normal now.