search

michaelworm / SoDaReloaded-Theme

Dark and light custom UI themes for Sublime Text 3 optimized for better readability.
131 stars 17 forks source link

Light Variant #9

Closed pradyunsg closed 9 years ago

pradyunsg commented 9 years ago

Hi!

Could you please create a light variant for this theme? I really like the idea but as I currently use 2 different colour-schemes (light/dark) as per the room lighting, the lack of a light variant hurts.

michaelworm commented 9 years ago

Hey,

sure I'm on it ;)

michaelworm commented 9 years ago

@pradyunsg see the master branch for the light variant. The icons seem to be a bit too bright for the light version, do you have an idea where I can get better icons?

pradyunsg commented 9 years ago

I'll look into it. If needed, I'll modify the existing ones for it...

But that's if and when I get some free time this evening.

michaelworm commented 9 years ago

Yea sure would be nice though :)

pradyunsg commented 9 years ago

Bazinga! (Because I sounded too formal. :stuck_out_tongue:)

pradyunsg commented 9 years ago

Nope, I won't be able to do this today.

Well, if you have GIMP installed, you should be able to make the relavant changes through the Hue-Saturation tool. http://docs.gimp.org/en/gimp-tool-hue-saturation.html

pradyunsg commented 9 years ago

Whoops!

michaelworm commented 9 years ago

@pradyunsg Do you know how I can use different icons for the two variants? Honestly I have no idea how to configure that..

pradyunsg commented 9 years ago

One way would be to place the two theme files in separate folders and have icon folders in them.

Like:

Theme - SoDaReloaded/
    light/
        icons/
        SoDaReloaded Light.sublime-theme
    dark/
        icons/
        SoDaReloaded Dark.sublime-theme

As long as you don't change the name of the theme file, it'll work just fine. Also, I recommend putting the "dark" and "light" folders into a "themes" folder. (From issue 32 @ sublimehq/Packages, because I don't want to link that issue here.)

michaelworm commented 9 years ago

Ahh I see. I didn't move the .sublime-theme Files into the folders that's why it didn't work for me. Hm I don't see any benefit to add another folder-level. Also they say that adding subdirectories will remove noise and I think we don't have too many files so it is not disturbing and unorganized :)

michaelworm commented 9 years ago

Btw I made a new branch for this enhancement, see https://github.com/Miw0/sodareloaded-theme/tree/light-variant-icons

pradyunsg commented 9 years ago

That's true.

I'll see this once I get better... (I fell ill today :confused:)

pradyunsg commented 9 years ago

I didn't get well. :/

Great to see that this is released! :smile:

Just one thing, you forgot to update the screen-shot of the light variant in the readme, with the newer icons.

michaelworm commented 9 years ago

Well I guess you misunderstood something :) I just made a new branch and moved things to the correct place. I didn't have time to make new icons yet..

michaelworm commented 9 years ago

Closing this now because the Light variant is working and released. I made a new issue for the icons, see #14

pradyunsg commented 9 years ago

Ah well. I did. :stuck_out_tongue: