funtom-io
commented
11 years ago I have commited the changes in the POM to the fork in https://github.com/OzMolaim/testfun_fork_dependencies. I made a sanity test on my local machine and it looks fine.
Dependencies that can stay with 'provided' scope:
- lombok : Lombok is only interesting in compile time.
Dependencies that I think that the scope element should be removed for them:
- mockito-all 1.9.5
- json-path-assert 0.8.1
- jsonassert 1.2.0
- fest-assert
- resteasy-jettison-provider
- commons-codec
- resteasy-multipart-provider
- org.jboss.resteasy.tjws
- validation-api
- commons-lang
Dependencies which I have douts whether to remove the provided scope or not (Currently removed in my fork):
- junit 4.8.1 : Since the user using testfun he has JUnit. The reson that I removed it is that @Rule annotation was added to JUnit on v4.7 and maby the user does not have v4.7 or higher. Another approch is to declare that testfun supports JUnit 4.7 or higher.
- jboss-ejb-api_3.1_spec : I did not check what heppens when testing simple JAX-RS web app (with no EJBs).
- jboss-jaxrpc-api_1.1_spec
- resteasy-jaxrs : Do we support Jersy? I guess it can stay 'provided' if the answer is no (I belive that all Rest-Easy applications should have it).
- resteasy-jaxb-provider (almost sure that we have to remove the 'provided' scope for that)
- hibernate-validator
- hibernate-jpa-2.0-api
- hibernate-entitymanager
- log4j
Michael, Please review the updated POM file in the fork I created. Ignore the iml files that where committed by mistake.
michaelyaakoby
Currently most of the dependencies in testfun's POM have the 'provided' scope. It means that unit tests that uses testfun 0.8 will not run unless the user adds the dependencies to his POM manually.
We should decide which are the dependencies we want to keep as provided and for which dependencies we will remove the scope.
I created a new fork 'testfun_fork_dependencies' and we firstly work on that fork in order to fix the issue.