michaelzangl / minebot

Minebot
GNU General Public License v3.0
146 stars 48 forks source link

Migrate to MC 1.12 #167

Open michaelzangl opened 7 years ago

michaelzangl commented 7 years ago

While making the source compatible to MC 1.12, the bot still handles it as if it was MC 1.8. To fix this, all new features need to be added.

Things to do: No programming skills required

easy

harder

ghost commented 7 years ago

One question, what do i have todo to fix the fishing splash sound id? You only need the id? would be entity.bobber.splash Or am i wrong with this? Also currently working on Blocksets...

michaelzangl commented 7 years ago

This might be enough. It needs some testing on how the ID is handled internally (a resource id object), but basically it just needs to be added to the network handler and then checked if there are no more bugs.

ghost commented 7 years ago

Where to put this: entity.bobber.splash ? So that i can test if fishing works again.

michaelzangl commented 7 years ago

Search the network controller. It has a TODO in it

ghost commented 7 years ago

network contoller? sry im a absolute beginner :P

michaelzangl commented 7 years ago

MinebotNetHandler, line 210

ghost commented 7 years ago

thx :P

ghost commented 7 years ago

another stupid question.... where to insert entity.bobber.splash? //TODO: Check this name if ("random".equals(name.getResourceDomain()) && "splash".equals(name.getResourcePath())) {

at first i wanted to do it this way:

if ("entity.bobber.splash".equals(name)) { but it didn`t work.... hepl pls.

Sent from my Google Nexus 5X using FastHub