michaelzangl / minebot

Minebot
GNU General Public License v3.0
146 stars 48 forks source link

Some feedback on this code #283

Closed VonHirsch closed 4 years ago

VonHirsch commented 5 years ago

Sorry, I know you didn't ask, but I feel compelled to give some feeback on this repo:

Pros:

Cons:

Thanks for making this code public! However due to its convoluted nature it is very difficult to patch, modify or customize. Please don't take this personally, i've written plenty of spaghetti code myself :)

michaelzangl commented 4 years ago

Feel free to improve. The problem with the bot are the many layers of abstraction, especially in the path finder. And the need to make it fast (really fast).

I'm closing this issue because it is too general. If you have any suggestions about specific parts of the code, feel free to open a new one.