michaelzangl / minebot

Minebot
GNU General Public License v3.0
146 stars 48 forks source link

Forge 1.16.3 #307

Closed Vaccinate closed 4 years ago

Vaccinate commented 4 years ago

Hey bud, Ported to 1.16.3 :) Small bugs still persist but it is usable. Run hasn't been implemented but those of you looking for a strip miner should use minebot stack / mine nearby / tunnel branches Thanks for the great mod!

michaelzangl commented 4 years ago

My bad for pushing my .idea, delete it if it gives you any problems :)

No Problem. I just pushed mine, so my .idea might have given you some.

Feel free to delete the files (vcs, ...) that don't need to be in the git because idea auto-creates them. I don't know a good way to not include the local path in the run configuration, in contrast to eclipse, IntelliJ does not support placeholders there.

Vaccinate commented 4 years ago

Your code is still taken into account - the extra code on top just boosts the final rating if it is the preferred tool with some exceptions - Wool, Logs, Wooden Planks etc. don't have a preferred harvest tool - so I boost scores of shears or axes accordingly. Similarly, clearing cobwebs would be "problematic" because it would be shears or sword based on speed - so we default to shears first if applicable. Either way, it fixes the problem but I'll take a look :) I did the blockset in this way because it would be a nightmare to port up to 1.17 if you had to redo all the func_anjhj_NH again with checking real names and converting.

michaelzangl commented 4 years ago

Your code is still taken into account - the extra code on top just boosts the final rating if it is the preferred tool with some exceptions - Wool, Logs, Wooden Planks etc. don't have a preferred harvest tool - so I boost scores of shears or axes accordingly.

You can do this in the MatchesRater. Overwrite the method getPow(). Return 1 normally, return 1.001 for your preferred block/tool match.

Vaccinate commented 4 years ago

:+1: I'll take a look, also at the speed thing. So I tried with: (item.getDestroySpeed(Block.getStateById(forBlockAndMeta)) > 1 in overridden getPow but ratePowed is never called. I couldn't get it to work in the time I had ): I also think I need to add planted beetroot seed to the BlockSet because the bot got scared of it

Vaccinate commented 4 years ago

Airbridge and fill still don't work for me (and haven't), not too sure

michaelzangl commented 4 years ago

I merged this pull request. Feel free to open more ;-)