External Intercom

[Saborknight]

When merged this pull request will:

• Let people ACE Interact with a vehicle to pickup/put away an intercom phone, allowing them to speak on the intercom of any ground vehicle
• Let people ACE Interact with a vehicle to connect wirelessly to the vehicle's intercom, allowing them to speak on the intercom of any ground or air vehicle, assuming that they're wearing compatible headgear
• Whenever a player wearing a wireless compatible headgear jumps out of an intercom capable vehicle's non-cargo seat, they are automatically connected to the intercom wirelessly, so that they can continue talking on the intercom without having to interact
• In all above cases, each of the two methods have their distinct maximum range of operation (Phone: 5m, Wireless: 15m). These values are customisable via CBA Settings

I'll be adding to this pull request with any suggested edits made, and by covering the below currently un-handled situations. I think I'm done in terms of adding new features. I'll also be making another pull request which will implement the physical telephone and rope, to add to immersion. So it turns out I've done everything in one pull request. Oh well.

Situations to handle correctly

• [x] Player moves outside of the 5 meter limit -> Intercom phone disconnected
• [x] Another player tries to pickup an intercom phone whilst someone else has already picked up the same phone -> Display an "Intercom phone is in use" ACE Interaction instead of the "Pickup Intercom Phone" ACE interaction. Also, Intercom phone will not activate if already in use, in case the ACE interaction is bypassed
• [x] Player is killed, or disconnects from the server whilst connected to the intercom phone -> Intercom phone disconnected
• [x] Player gets into the same vehicle they are connected to with the intercom phone -> Intercom phone disconnected
• [x] Player gets into any vehicle whilst they are connected to the intercom phone -> will disconnect, though the distance checks should come into play if the vehicle the player is in, or the vehicle they are connected to move outside of the 5 meter radius
• [x] Player picks up another intercom phone whilst still being connected to a different intercom phone -> will disconnect old intercom phone
• [x] Player going unconscious (ACE) whilst being connected to the intercom phone -> will disconnect

Todo for this initial implementation (AKA 1.0?)

• [x] Add: option to disable external intercom, or only same side can connect
• [x] Add: Have wireless headgear reconnect automatically in case someone runs out of range by mistake. Make it so that they must disconnect via self interaction.
• [x] Allow wireless users to change intercom channel
• [x] Add: channel switch to phone panel, not self interact
• [x] Add: attribute that can be added to individual vehicle from Eden, Config or Zeus(?) to customise max range of phone and/or wireless
• [x] Fix: When jumping out of a vehicle, the intercom does stay connected wirelessly, but the icon doesn't appear?
• [ ] Fix: Rope breaking doesn't disconnect
• [x] Fix: AI jumping out will show indicator icon, even if Zeus is not on intercom
• [x] Fix: Now Headgear whitelist is suddenly not being transferred from server to client anymore...?
• [x] When being connected to wireless intercom, and changing the "Enable" setting to "Same side as Player", ropes attach to all players currently connected to the wireless intercom. So, one of the 2 players was given the rope and phone, but not actually assigned as phone operator... Meaning that player now can't put away the attached rope and phone
• [x] When one wireless user disconnects, all players lose the wireless indicator. This does not apply to someone when jumping in the vehicle (and wireless intercom disonnecting normally for them)
• [x] When a phone user is connected, and a crew member jumps out of the vehicle, the phone and cable disappear but icon remains, and intercom is still connected
• [x] When a wireless user takes helmet off, whilst another user is connected to wireless, it removes the phone and cable, but icon remains and intercom stays connected
• [x] Changing server settings don't apply globally
• [x] When no users are connected to the phone, but all are connected to the wireless, and the setting Enable is changed to something, then a random user (I assume first in the list) is actually connected to the phone instead of the wireless, and the other users are disconnected completely
• [x] When 2 users connected wirelessly, and setting gone from 1 to 2, locally each user is still considered connected, but the TFAR_ExternalIntercomSpeakers variable of the vehicle is not syncronised so we're each seeing an option to disconnect ourselves
• [x] When in crew seat, change to crew, then dismount. The channel will not remain on crew, it'll switch back to default
• [x] Connecting to wireless, getting into crew position, then getting out will duplicate person entry in TFAR_ExternalIntercomSpeakers of the vehicle
• [x] A player who isn't connected to intercom at all will have the icon appear randomly when another player jumps out of the vehicle
• [x] Modded Vehicles don't have the Intercom Phone interaction points?
• [x] Add entry to ACE Arsenal to indicate if a headgear is External Intercom Compatible
• [ ] When all users are connnected to the wireless and the Enable setting is changed to 2, the second player in the list still has the "Disconnect Wireless" ACE interaction showing on the vehicle, even though they've been otherwise completely disconnected
• [ ] A player (previously connected to wireless) isn't disconnected from the intercom when disconnecting from the server
• [ ] Fix: Make sure fnc_getIntercomChannel sorts the array by commander > gunner > driver > passengers instead of the current sorting Not so important if we just give the ability for the person to change channel themselves

Note: Credits to Gary Sinise for donation of the handset model as well as corrections to certain calculations involved (He's the Maths voodoo man)

[Saborknight]

I'm going to add these to the todo list: Add option to disable this, or only same side can connect Idea: Have wireless headgear reconnect automatically in case someone runs out of range by mistake. Make it so that they must disconnect via self interaction. Also, allow wireless users to change intercom channel Add channel switch to phone panel, not self interact Add attribute that can be added to individual vehicle from Eden, Config or Zeus(?) to customise max range of phone and/or wireless Issue: When jumping out of a vehicle, the intercom does stay connected wirelessly, but the icon doesn't appear? Issue: Rope breaking doesn't disconnect

[Saborknight]

Some change since the last review has caused the headgear setting not to be transferred to clients anymore? When I fetch the setting from the server, it looks the way it should, but when I just try and use the global variable normally via just stating it, it comes up blank. I was under the impression that CBA would handle the transfer of the variable to any clients with the onChange parameter.... but it looks like I need to do it manually...

[nomisum]

eagerly waiting for this, want to use that rope and model as a dependency for a telephone mod :)

love the external intercom feature too.

[Saborknight]

Is this waiting on anything else? I can't really make any more changes past the 26th as I'm hoping to be in the military and therefore won't be available at that point. So, anything that you guys need from me, please let me know beforehand. Thanks

[dedmen]

Ugh... Many build errors. ACEActions.hpp has two TFAR_Radios classes, that can't be. CustomInteractionPoints.hpp has multiple base class declarations for B_APC_Tracked_01_base_F, that also can't be. And O_APC_Tracked_02_base_F too, and Tank_F,...

config.cpp has multiple CfgVehicles..

[dedmen]

18:51:00 Unexpected stringtable format inside <Text ID="STR_TFAR_EXTERNAL_INTERCOM_SOMEONE_USING_PHONE"><Original>
18:51:00 Unexpected stringtable format inside <Text ID="STR_TFAR_EXTERNAL_INTERCOM_SOMEONE_USING_PHONE"><English>
18:51:00 Unexpected stringtable format inside <Text ID="STR_TFAR_EXTERNAL_INTERCOM_SOMEONE_USING_PHONE"><Czech>
18:51:00 Unexpected stringtable format inside <Text ID="STR_TFAR_EXTERNAL_INTERCOM_SOMEONE_USING_PHONE"><Russian>
18:51:00 Unexpected stringtable format inside <Text ID="STR_TFAR_EXTERNAL_INTERCOM_SOMEONE_USING_PHONE"><Italian>
18:51:00 Unexpected stringtable format inside <Text ID="STR_TFAR_EXTERNAL_INTERCOM_HEADGEAR_NOT_WIRELESS_CAPABLE"><Original>
18:51:00 Unexpected stringtable format inside <Text ID="STR_TFAR_EXTERNAL_INTERCOM_HEADGEAR_NOT_WIRELESS_CAPABLE"><English>
18:51:00 Unexpected stringtable format inside <Text ID="STR_TFAR_EXTERNAL_INTERCOM_HEADGEAR_NOT_WIRELESS_CAPABLE"><Czech>
18:51:00 Unexpected stringtable format inside <Text ID="STR_TFAR_EXTERNAL_INTERCOM_HEADGEAR_NOT_WIRELESS_CAPABLE"><Russian>
18:51:00 Unexpected stringtable format inside <Text ID="STR_TFAR_EXTERNAL_INTERCOM_HEADGEAR_NOT_WIRELESS_CAPABLE"><Italian>

😢