michail-nikolaev / task-force-arma-3-radio

TeamSpeak integration for Arma 3
http://radio.task-force.ru/en/
Other
314 stars 169 forks source link

Hear from Splendid Camera #1538

Closed ampersand38 closed 2 years ago

ampersand38 commented 3 years ago

When merged this pull request will:

nomisum commented 3 years ago

got the following error

case "Open": {
23:01:16 Error in expression <_eventType do {
case "Open": {
_display displayAddEventHandler ["KeyDown", "[_th>
23:01:16   Error position: <displayAddEventHandler ["KeyDown", "[_th>
23:01:16   Error displayaddeventhandler: Type Number, expected Display (dialog)
23:01:16 File z\tfar\addons\core\functions\events\fnc_onSplendidCamera.sqf..., line 25
23:01:16 Error in expression <_eventType do {
case "Open": {
ampersand38 commented 3 years ago

got the following error

case "Open": {
23:01:16 Error in expression <_eventType do {
case "Open": {
_display displayAddEventHandler ["KeyDown", "[_th>
23:01:16   Error position: <displayAddEventHandler ["KeyDown", "[_th>
23:01:16   Error displayaddeventhandler: Type Number, expected Display (dialog)
23:01:16 File z\tfar\addons\core\functions\events\fnc_onSplendidCamera.sqf..., line 25
23:01:16 Error in expression <_eventType do {
case "Open": {

Ah thank you. It was left over from a very half-hearted attempt at seeing if keybinds will work.

dedmen commented 3 years ago

I don't understand why you need to add this? This should've already been a thing

dedmen commented 3 years ago

Overall I think all that TFAR_fnc_onSplendidCamera should do, is enable/disable TFAR_fnc_forceSpectator (depending on setting, if you want that). That fixes all the stuff you forgot, and that already does all the stuff you wanted to do here.

If you say no it needs to be like this, and yes you thought about all I mentioned and want to keep it this way then I'd be fine with that too.

ampersand38 commented 3 years ago

Overall I think all that TFAR_fnc_onSplendidCamera should do, is enable/disable TFAR_fnc_forceSpectator (depending on setting, if you want that). That fixes all the stuff you forgot, and that already does all the stuff you wanted to do here.

If you say no it needs to be like this, and yes you thought about all I mentioned and want to keep it this way then I'd be fine with that too.

There are definitely aspects of this I haven't fully considered. The use case is for authorized players to be able to record footage using Splendid Cam's advantages over Spectator or Curator views, with TFAR local voice, during down time in an op. I'll try to understand and address your individual concerns.