search

michal-h21 / vim-zettel

VimWiki addon for managing notes according to Zettelkasten method
MIT License
559 stars 73 forks source link

fix for breaking changes in the current vimwiki dev branch #37

Closed Burnit closed 4 years ago

Burnit commented 4 years ago

The current dev branch of vimwiki introduced some breaking changes in their interface and tags handling. This commit adpts vim-zettel to this changes.

michal-h21 commented 4 years ago

Thank you for the fix :)

0x6a68 commented 4 years ago

@michal-h21 This forces vim-zettel users to use the vim-wiki dev branch, because this merge has no backward compatibility to the vim-wiki master branch. I suggest to either update the install instructions (README.md) or to revert this PR.

michal-h21 commented 4 years ago

@jhattwich ah, that's bad. I've reveted it. Do you know if it is possible to detect the dev version of Vimwiki and use the correct commands according to that info?

Burnit commented 4 years ago

Sorry! my bad. I should have made the change more clear. Been a long day of learning vim script.

michal-h21 commented 4 years ago

@Burnit no, it is really useful. I knew that development version broke this function and I wasn't able to came with a solution, so thanks for that. Now I introduced a new function, zettel#vimwiki#update_listing, which is defined depending on the existence of vimwiki#base#deprecate function, which is introduced in the dev branch of Vimwiki. It uses your code with the dev version, the original code is used otherwise. I've tested it with both branches and it seems to work.

ghost commented 4 years ago

One vimwiki-update to crash them all. maybe it makes more sense to make a separate independent vim-zettel-plugin ^^

michal-h21 commented 4 years ago

@Real-Otternaut Except for this I didn't experience more issues with the devel branch. It is always bit of nightmare when you use internal functions of some software you don't control and this is not the first time things broke because of the upstream changes. But I think keeping with the changes is still easier to build a new thing from scratch. Majority of vim-zettel functionality is still provided by Vimwiki.

More serious issue is that I didn't have energy to keep with all new submitted issues in the past months, as I was busy with other stuff. I hope to fix them in the near future.

ghost commented 4 years ago

I‘m absolutely with you. But I got a lot of vim-Zettel GitHub messages these days and thought: damn Vimwiki is sometimes a nightmare. Especially as a dependency.

michal-h21 commented 4 years ago

@Real-Otternaut yeah, I am quite overwhelmed by the new issues in past few months. Zettelkasten seems to be quite popular now, I see new articles almost every day and number of vim-zettel users doubled. I hope that most of the issues are minor, I just have to find an energy to deal with all of them :/

0x6a68 commented 4 years ago

vim-wiki 2.5 has been released

michal-h21 commented 4 years ago

@0x6a68 thanks for the info. The fix seems to work, it is only necessary to rebuild the tag index using :VimwikiRebuildTags.

Burnit commented 4 years ago

@michal-h21 Thank you a lot, i am glad i could help :) I hope i can contribute more in the future.