search

michalber / spdmon

A simple to use progress bar for C++
MIT License
12 stars 3 forks source link

Nice work! #1

Open epruesse opened 3 years ago

epruesse commented 3 years ago

Thanks for starting this project! I always meant to separate the progress bar out of SINA - it was really just in there for convenience because I was lacking time.

Can you put me into the authors list here? The code is derived after all (I do recognise some of my lines). I'll toss the code out of SINA and use this instead. We can also drop the references to "SINA's progress monitor" I think.

Where there any features you dropped? IIRC I've got some code to log at larger intervals with regular lines if the sink isn't a terminal.

michalber commented 3 years ago

No problem, it is pleasure for me and occasion to learn something new 🤓

Sure I do. I will update repo soon and get rid of these "SINA"s" references.

I do not know if I understand you correctly but to get rid of modifying spdlog library I needed to hardcode default progress logger to use stdout (instead of using private FILE *target_file_ from spdlog sink). I was able to correctly log to both progress sink and file sink (example on the end of Readme or in src/example.cpp).

epruesse commented 3 years ago

to get rid of modifying spdlog library I needed to hardcode default progress logger to use stdout (instead of using private FILE *targetfile from spdlog sink)

I'll have to look over the code and changes. I'm sure minor modifications to spdlog that do not impact its performance will be accepted there.