michalchudziak / react-native-geolocation

Geolocation APIs for React Native
MIT License
1.28k stars 220 forks source link

use latest play services version 21.0.1 #249

Closed marchinram closed 1 year ago

marchinram commented 1 year ago

Overview

Google released play-services-location 21.0.1 back in 11/2022 so seems like a good time to update, also due to other dependencies requiring 21.0.1 my project resolves to this version, when I attempt to use react-native-geolocation with 21.0.1 in my app I get the following error: Screenshot_1681836121

This is actually fixed by updating to 21.0.0 however seems better to update to latest.

Test Plan

Ran all tests in the package.json scripts section, ran sample app and tested it worked, and tested in my own app where I initially noticed the issue, tested changes by updating @react-native-community/geolocation in dependencies to use local path of git repo for my fork.