search

michaldaniel / ebook-viewer

Modern GTK Python Ebook Reader app to easily read epub files
GNU General Public License v3.0
406 stars 47 forks source link

Header bar icon inconsistency (use symbolic icons) #28

Open keeferrourke opened 7 years ago

keeferrourke commented 7 years ago

For the GUI to have a consistent look across different icon themes, you should stick with either the symbolic icon set (as is recommended for GNOME applications) or the regular icon set.

In header-bar.py for instance, it seems that you're using (perhaps unintentionally) a mix of symbolic and regular icons.

I would recommend changing the header-bar to use only symbolic icons. Problematic lines include:

 49        document_open_image = Gtk.Image.new_from_icon_name("document-open", Gtk.IconSize.LARGE_TOOLBAR)`
139        document_properties_image = Gtk.Image.new_from_icon_name("open-menu", Gtk.IconSize.LARGE_TOOLBAR)`

Simply append -symbolic to each icon name listed above to resolve the issue.

ghost commented 6 years ago

Cool it is fixed. And it should be closed ;)