search

michaldrabik / showly-2.0

Showly 2.0 is modern, slick, open-sourced Android TV Shows Tracker.
http://www.showlyapp.com
GNU General Public License v3.0
798 stars 54 forks source link

Submit to F-Droid #46

Open roshavagarga opened 4 years ago

roshavagarga commented 4 years ago

Have you considered submitting Showly to F-Droid?

michaldrabik commented 4 years ago

Will probably do it when I've got some free time and app is out of open beta.

IzzySoft commented 3 years ago

There will be some issues:

  implementation "com.google.firebase:firebase-analytics-ktx:$versions.firebaseAnalytics"
  implementation "com.google.firebase:firebase-messaging:$versions.firebaseMessaging"
  implementation "com.google.firebase:firebase-crashlytics:$versions.crashlytics"

Firebase (as well as Google Services and some more) is not acceptible by F-Droid, as it's proprietary. So this would need a special build flavor coming without Firebase. Would that be possible?

michaldrabik commented 3 years ago

Probably! But I am postponing submission to F-Droid for further date (it's not that trivial as I can see) when I'm happy with complete set of features and stability of the app.

IzzySoft commented 3 years ago

Should you have a build without those, and provide the APK e.g. attached to your releases, please let me know here. I could then add it to my repo until you're ready for "F-Droid proper".

IzzySoft commented 2 years ago

Unfortunately not – I'm not a developer, and I never wrote any Github action script (nor worked on development tasks of an Android app)… But a suggestion which might also solve the issue: I guess you need that for Cloud Messaging, right? In that case, you could maybe replace FCM by UnifiedPush. Then those who want FCM can use its FCM-distributor – and everyone else can choose between Gotify and Nextcloud (also see here for some notes). As the distributor comes separate, there are no non-free dependencies. Which would only leave the analytics to be dropped (or replaced).

One more pointer, as you probably would like to have the FCM distributor built-in for your PlayStore releases: you should look into establishing build flavors (a nice tutorial can be found here, the official documentation here. Establish one flavor for PlayStore (e.g. gplay) that then comes with FCM – and another one (e.g. foss) that comes without. Then it's a simple command at build time to decide which flavor/variant to build.

rollingmoai commented 1 year ago

The FOSS fork mentioned in https://github.com/michaldrabik/showly-2.0/issues/537#issuecomment-1487634318 is available in Izzy's repo 🎉 https://apt.izzysoft.de/fdroid/index/apk/com.michaldrabik.showly_oss

There are missing things though, as mentioned in https://github.com/michaldrabik/showly-2.0/issues/537#issuecomment-1488748065

realgooseman commented 2 months ago

Hi @michaldrabik,

Now that Showly offers a FOSS variant directly in it's GitHub releases, the fork from 1RandomDev isn't really needed anymore. So could we see the FOSS variant of Showly 2.0 on IzzyOnDroid along with the regular version on Play Store ?

I'd suggest using IzzyOnDroid repo over F-Droid because the releases keep same signing keys and are published faster.