search

michaljach / ember-cli-deploy-scp

Easily deploy your Ember applications via ssh using scp.
MIT License
1 stars 0 forks source link

Node config #24

Closed pfmmfp closed 7 years ago

pfmmfp commented 7 years ago

To make it work, instead of configuring my node as explained in the doc,

    ENV['scp'] = {
      nodes: [{
        username: '<ssh-username>',
        host: '<ssh-host>',
        path: '<remote-server-path>',
      }],
    }

I had to remove the nodes array,

    ENV['scp'] = {
        username: '<ssh-username>',
        host: '<ssh-host>',
        path: '<remote-server-path>',
    }

Using v1.0.9.

michaljach commented 7 years ago

Maybe @sandstrom can help with this, I'm away for a next week.

sandstrom commented 7 years ago

@pfmmfp Can you describe the issue a bit more. Did you get any error messages?

rennomarcus commented 7 years ago

I think what happened here is that the code that handles the nodes array was not released. Yet the documentation asks to use it. Release 1.0.9 did not include commit b09438f92faebd984e13bee6007ed1c1284f6226 which changes this code... and the documentation was also changed later in commit 852f4715ce508bbfdd6272aa49ef0ef765e84abb With that said, I believe that with a new release this issue will be solved :)

sandstrom commented 7 years ago

Thanks @rennomarcus!

@pfmmfp Something like this should solve your issue. Does that help?

pfmmfp commented 7 years ago

Thanks for proposing that fix @sandstrom. I'm fine with one node, but I guess that could work for anybody wanting to use many nodes.

michaljach commented 7 years ago

1.0.10 released !

sandstrom commented 7 years ago

@pfmmfp Can you try with 1.0.10 and see if the first syntax you posted (from readme) works for you?

pfmmfp commented 7 years ago

1.0.10 fixes the issue. Thanks! 👍

For the record, this is the error I was getting:

- Missing required config: `username`
Error: Missing required config: `username`
Error: Missing required config: `username`
    at CoreObject.ensureConfigPropertySet (/Users/pol/projects/alarm.com/AlarmStyleGuide/poc-style-guide/node_modules/ember-cli-deploy-plugin/index.js:57:13)
    at Array.forEach (native)
    at CoreObject.configure (/Users/pol/projects/alarm.com/AlarmStyleGuide/poc-style-guide/node_modules/ember-cli-deploy-plugin/index.js:39:19)
    at Object.fn (/Users/pol/projects/alarm.com/AlarmStyleGuide/poc-style-guide/node_modules/ember-cli-deploy/lib/tasks/pipeline.js:93:21)
    at Pipeline._notifyPipelinePluginHookExecution (/Users/pol/projects/alarm.com/AlarmStyleGuide/poc-style-guide/node_modules/ember-cli-deploy/lib/models/pipeline.js:173:19)
    at tryCatch (/Users/pol/projects/alarm.com/AlarmStyleGuide/poc-style-guide/node_modules/rsvp/dist/rsvp.js:525:12)
    at invokeCallback (/Users/pol/projects/alarm.com/AlarmStyleGuide/poc-style-guide/node_modules/rsvp/dist/rsvp.js:538:13)
    at publish (/Users/pol/projects/alarm.com/AlarmStyleGuide/poc-style-guide/node_modules/rsvp/dist/rsvp.js:508:7)
    at flush (/Users/pol/projects/alarm.com/AlarmStyleGuide/poc-style-guide/node_modules/rsvp/dist/rsvp.js:2415:5)
Pipeline aborted
sandstrom commented 7 years ago

Good! Feel free to close this issue