search

michalkielan / MatrixLibs

Small matrix library, written C++11
Mozilla Public License 2.0
1 stars 2 forks source link

Conv2 enhancement. #19

Closed JaroslawWiosna closed 7 years ago

JaroslawWiosna commented 7 years ago

No mattter what return value of isOutOfRange(it,jt) is, result[it][jt] is always zero. This is very bad, but I can't see where the mistake is.

JaroslawWiosna commented 7 years ago

Here is what current implementation returned (current means e37881a )

1.9998 3.9996 6.9993 4.9995 2.9997 2.9997 5.9994 9.999 6.9993 3.9996 3.9996 7.9992 12.9987 8.9991 4.9995 1.9998 3.9996 5.9994 3.9996 1.9998 0.9999 1.9998 2.9997 1.9998 0.9999

and below is what octave returned

6    9   10   11    8
8   12   13   14   10
8   12   13   14   10
6    9    9    9    6
4    6    6    6    4
JaroslawWiosna commented 7 years ago

22 <-- issue

JaroslawWiosna commented 7 years ago

@michal915 ready to merge

JaroslawWiosna commented 7 years ago

Conflicts! Have a look at #26