michalmikolajczyk / viking-garage-frontend

VIKING GARAGE app
MIT License
10 stars 2 forks source link

Create language and currency selection #175

Closed jasiek-net closed 7 years ago

jasiek-net commented 7 years ago

As an user I want to pick up from app bar menu language and currency.

michalmikolajczyk commented 7 years ago

@jonzee please do not add a settings button

michalmikolajczyk commented 7 years ago
as a user,
I want to be able to set the language of the app,
on every view, directly from the app bar
as a user,
I want to be able to set the currency,
on every view, directly from the app bar
jasiek-net commented 7 years ago

I created pull request #176 with language selection, now I want to discuss the currency selection. For now currency is strictly connected with translations (so I have to rewrite some parts of code) and I would create a new pr with this feature. I'm not sure where to add currency button. In desktop there are 5 buttons in menu, and I'm not sure if another long button (Currency (USD)) would be fine. I tried to use some icons (like world_icon (PL)) but it wasn't ok. @michalmikolajczyk, @lam3lka what do you think?

michalmikolajczyk commented 7 years ago

Chodziło mi o string z kodem języka "PL" gdzieś w app bar, np. Jako drugi element od prawej. Lub trzeci od prawej, bo drugim powinna być waluta. Można dać tak: <ikona> <string> <flag> PL | <coins> PLN Flaga ikonka ogólna, nie Polski

jasiek-net commented 7 years ago

ok, added to #176

michalmikolajczyk commented 7 years ago

ok.

screen shot 2017-07-27 at 1 07 34 pm
michalmikolajczyk commented 7 years ago
screen shot 2017-07-27 at 1 07 34 pm
jasiek-net commented 7 years ago

added in #176

michalmikolajczyk commented 7 years ago

good work