Closed jasiek-net closed 7 years ago
@jonzee please do not add a settings button
as a user,
I want to be able to set the language of the app,
on every view, directly from the app bar
as a user,
I want to be able to set the currency,
on every view, directly from the app bar
I created pull request #176 with language selection
, now I want to discuss the currency selection
. For now currency is strictly connected with translations (so I have to rewrite some parts of code) and I would create a new pr
with this feature.
I'm not sure where to add currency
button. In desktop there are 5 buttons in menu, and I'm not sure if another long button (Currency (USD)
) would be fine. I tried to use some icons (like world_icon (PL)
) but it wasn't ok.
@michalmikolajczyk, @lam3lka what do you think?
Chodziło mi o string z kodem języka "PL" gdzieś w app bar, np. Jako drugi element od prawej. Lub trzeci od prawej, bo drugim powinna być waluta. Można dać tak:
<ikona> <string>
<flag> PL | <coins> PLN
Flaga ikonka ogólna, nie Polski
ok, added to #176
ok.
added in #176
good work
As an user I want to pick up from app bar menu language and currency.
Language
to menupl/en