search

michalmuskala / plug_attack

A plug building toolkit for blocking and throttling abusive requests
419 stars 21 forks source link

Update deps and docs #27

Open ryanwinchester opened 10 months ago

ryanwinchester commented 10 months ago

It's nice to see modern docs and it's nice when docs link to the repo/source code.

michalmuskala commented 10 months ago

Thanks, this looks pretty good.

However, I think the 18.04 runner for github actions has been sunset. Could you update to 20.04? I recently updated the Jason CI versions, if you need some reference https://github.com/michalmuskala/jason/blob/master/.github/workflows/ci.yml

ryanwinchester commented 10 months ago

However, I think the 18.04 runner for github actions has been sunset. Could you update to 20.04?

The table from erlef/setup-beam:

Operating system Erlang/OTP Status
ubuntu-18.04 17 - 25 ✅
ubuntu-20.04 20 - 25 ✅
ubuntu-22.04 24.2 - 25 ✅
windows-2019 21* - 25 ✅
windows-2022 21* - 25 ✅

means we have to change the elixir/otp combos up too i guess

michalmuskala commented 10 months ago

As you can see, the 18.04 jobs are just pending since github no longer provides runners with this os version. We can start testing from OTP 20 & Elixir 1.4 similar to Jason - older versions are for a long time no longer supported and I'm fine with dropping them from automated tests.

ryanwinchester commented 9 months ago

As you can see, the 18.04 jobs are just pending since github no longer provides runners with this os version. We can start testing from OTP 20 & Elixir 1.4 similar to Jason - older versions are for a long time no longer supported and I'm fine with dropping them from automated tests.

Yeah, you're right. Copied the Jason versions.

ryanwinchester commented 9 months ago

Should I roll back some of the deps updates?