Support %h %j %u %U %V %w %W %Z, and tests

michalmuskala / time_format

Fast date/time formatting for elixir

7 stars 3 forks source link

Support %h %j %u %U %V %w %W %Z, and tests #4

Closed martinsvalin closed 6 years ago

martinsvalin commented 6 years ago

I implemented these:

%h - Abbreviated month name * (same as %b)
%j - Day of the year (001-366)
%u - ISO 8601 weekday as number with Monday as 1 (1-7)
%U - Week number with the first Sunday as the first day of week one (00-53)
%V - ISO 8601 week number (01-53)
%w - Weekday as a decimal number with Sunday as 0 (0-6)
%W - Week number with the first Monday as the first day of week one (00-53)

I added tests for all supported format codes. I've kept tests simple so far, with only a few additional examples to help me get week numbers right.

martinsvalin commented 6 years ago

The test failure is on calling Calendar.ISO.date_to_iso_days/3 (in wday) on 1.5.x, where it was called Calendar.ISO.date_to_iso_days_days/3 (Note the extra _days). Both new and old have @doc false.

Calling :calendar.date_to_gregorian_days/3 as I did for year_day is one way to deal with it. Whatever we end up doing, we should call the same function in both places.

michalmuskala commented 6 years ago

Thank you! :heart: