michalpokusa / django-admin-action-forms

Extension for the Django admin panel that allows passing additional parameters to actions by creating intermediate pages with forms.
https://pypi.org/project/django-admin-action-forms/
MIT License
95 stars 3 forks source link

Keep the `extrahead` contents from the parent template #1

Closed matthiask closed 2 months ago

matthiask commented 2 months ago

Thanks for this project! Very useful.

I have an admin customization which replaces the nav sidebar with a panel with grouped apps (django-fhadmin); the necessary scripts and styles are added to the {% block extrahead %}. The django-admin-action-forms action form template replaces the contents of extrahead instead of adding to them, it would be great if that could be changed.

Thanks!

michalpokusa commented 2 months ago

Thanks for that, it seems like it should be there from the start, I must have missed it. I will check later today whether it should be at the top or bottom in order to not break any JS scripts for autocomplete, date widgets etc. and test different INSTALLED_APPS order just to make sure. I'll merge later if it works fine, which it most likely will.

Thanks

matthiask commented 2 months ago

Thank you! I'd appreciate a release containing this if you find the time, but as a maintainer of numerous projects myself I understand I'm asking a bit much here.

michalpokusa commented 2 months ago

I will make a release today, while testing this and working on #2 I found a few minor edge case bugs that I wanted to fix before.

michalpokusa commented 2 months ago

@matthiask I just released version 1.2.0 which includes this PR.

Thanks again for spotting this.