michalpolkowski / alt-f

Automatically exported from code.google.com/p/alt-f
0 stars 0 forks source link

Malformed HTML on the web interface #24

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Point your browser to the administrative web interface, right-click on the 
right-handed side of the page (frame on the right), then select "This Frame" -> 
"View Frame Source" and take a look at the code of affected pages (Firefox 
3.6.x marks/highlights malformed HTML tags in red)
2. This doesn't seem to be a major issue (or cause any problems with most 
browsers), but /could/ lead to unexpected/strange behaviour on some of the CGI 
scripts
3. While some of the patches/suggestions handle missing endings on a few tags, 
others just add enclosing quotes on the generated HTML to ensure any empty 
values are interpreted properly (as empty values/tags/whatever).

What is the expected output? What do you see instead?
A brief sanity check on customroot/usr/www/cgi-bin revealed the following files 
could/should be patched/updated in order to help/improve 
determinism/reliability of the web interface (interpretation of tags by the 
browser and/or any javascript code that might behave slightly different on 
different browsers/platforms):
common.sh
raid.cgi
proxy.cgi
diskmaint.cgi
diskwiz.cgi
dnsmasq.cgi
ddns.cgi
nfs.cgi
smb.cgi

What version of the product are you using? On what operating system?
Alt-F v0.1B6

Original issue reported on code.google.com by augu...@bott.com.br on 28 Dec 2010 at 7:34

Attachments:

GoogleCodeExporter commented 9 years ago
Applied, thanks.
Could you please use unified diff on you next contributions :-) ?

Original comment by whoami.j...@gmail.com on 7 Jan 2011 at 3:17