search

michalsta / opentims

Open-source C++ and Python module for opening binary timsTOF data files.
Other
44 stars 14 forks source link

add the na.rm argument required by the range generic. Closes #25 #26

Closed sneumann closed 2 months ago

sneumann commented 8 months ago

See getGeneric("range") for required method definition. Yours, Steffen

michalsta commented 8 months ago

Looks good to me, thanks. Matteo? You're the R guy here, mind having a look?

sneumann commented 8 months ago

Hi @MatteoLacki , one more background information is the entry in the R changelog mentioning the change: https://cran.r-project.org/bin/windows/base/old/4.3.3/NEWS.R-4.3.3.html I accidentally committed my wholesale change from name = function() {...} to name <- function() {...} which was an early attempt to tackle the issue (you never know in R ...). I didn't revert it because it is the style in the R manuals, e.g. https://adv-r.hadley.nz/functions.html, but I can do that if you want me to. Yours, Steffen

yufree commented 4 months ago

Hi, This PR added na.rm in the OpenTIMS and fixed the installation error mentioned in #25 . It should be safe to merge for other users to use this package.