search

michanismus / cssmin

Automatically exported from code.google.com/p/cssmin
0 stars 0 forks source link

Minification option "convert-css3-properties" don't get checked #13

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Run CSSmin on the attached site.css

What is the expected output? What do you see instead?
A smaller file size. 

I see a file that is larger than the original, exactly:
orig: 39440 / min: 42959
ratio: 108.9224137931%

What version of the product are you using? On what operating system?
Latest on OS X.

Please provide any additional information below.
Attached is the original file and the 'minified' file that CSSmin generated.

Original issue reported on code.google.com by mario.es...@gmail.com on 12 Aug 2010 at 2:40

Attachments:

GoogleCodeExporter commented 8 years ago 
This is the code I used for minification:
$css = CssMin::minify($css, array(
    'convert-css3-properties' => false,
    'compress-unit-values' => true,
    'compress-color-values' => true
));

Original comment by mario.es...@gmail.com on 12 Aug 2010 at 2:49

GoogleCodeExporter commented 8 years ago 
I actually found what's wrong, the property 'convert-css3-properties' is never 
being checked and so CSSmin always converts the css3 properties.

I really think that 'convert-css3-properties' and other configurations that 
make the file larger should be turned off by default. It's very misleading.

Original comment by mario.es...@gmail.com on 12 Aug 2010 at 2:55

GoogleCodeExporter commented 8 years ago 
Sorry for the spamming but here's my little patch for making the css3 
configuration work.

Original comment by mario.es...@gmail.com on 12 Aug 2010 at 3:08

Attachments:

GoogleCodeExporter commented 8 years ago 
Fixed in version 2.0.1.002.

The minification option "convert-css3-properties"  is now false by default. I 
agree with you that this makes more sense.

Original comment by joe.scylla on 12 Aug 2010 at 8:05

GoogleCodeExporter commented 8 years ago 
PS. thanks for reporting ;)

Original comment by joe.scylla on 12 Aug 2010 at 8:17