search

michaschwab / booc3

https://booc.io
Other
4 stars 1 forks source link

Segment Add: General 'External URL' content type #145

Closed jamestompkin closed 8 years ago

jamestompkin commented 8 years ago

Opens in new tab.

michaschwab commented 8 years ago

Is this separate from the iframe includer? How about having just one content type, but having a select box with "Embed" vs "External"? Now that I think of it, how about we automatically switch to "External" when a HTTP (not HTTPS) website is included, and notify? That way also taking care of #140

jamestompkin commented 8 years ago

Sounds good - like making the options 'Embed (HTTPS)' or 'External', and then grey out 'Embed' when it's not possible.

On 20 January 2016 at 17:51, Michail Schwab notifications@github.com wrote:

Is this separate from the iframe includer? How about having just one content type, but having a select box with "Embed" vs "External"? Now that I think of it, how about we automatically switch to "External" when a HTTP (not HTTPS) website is included, and notify? That way also taking care of #140 https://github.com/michaschwab/booc3/issues/140

— Reply to this email directly or view it on GitHub https://github.com/michaschwab/booc3/issues/145#issuecomment-173388701.

jamestompkin commented 8 years ago

Maybe 'Show in New Tab' instead of 'External' - they are all External.

On 20 January 2016 at 18:02, James Tompkin james.tompkin@gmail.com wrote:

Sounds good - like making the options 'Embed (HTTPS)' or 'External', and then grey out 'Embed' when it's not possible.

On 20 January 2016 at 17:51, Michail Schwab notifications@github.com wrote:

Is this separate from the iframe includer? How about having just one content type, but having a select box with "Embed" vs "External"? Now that I think of it, how about we automatically switch to "External" when a HTTP (not HTTPS) website is included, and notify? That way also taking care of #140 https://github.com/michaschwab/booc3/issues/140

— Reply to this email directly or view it on GitHub https://github.com/michaschwab/booc3/issues/145#issuecomment-173388701.