Roles: Actually make them work.

[michaschwab]

bd7220bf819ddc227213bb953fc26021faec4723 and 07726ff0bb541350facbb07ba272f200d300917d are working toward fixing this issue.

[michaschwab]

i did some more work today and think that TA rights are now fine. i'll change GK's teams' roles to those.

[jamestompkin]

We should run through this together before you do that.

On 2 February 2016 at 15:22, Michail Schwab notifications@github.com wrote:

i did some more work today and think that TA rights are now fine. i'll change GK's teams' roles to those.

— Reply to this email directly or view it on GitHub https://github.com/michaschwab/booc3/issues/184#issuecomment-178801975.

[michaschwab]

alright, you'll be our test case then :-) i revoked your admin privileges, but made you teacher of gov 2001 and james test course. let me know if everything works :-D

[michaschwab]

since this commit af6758ab8972fd2ed5b38baa5c0f95ea5ea162cd content editors can also access the admin panel, but only the functions relating to the material, not the concept-changing things.

[jamestompkin]

Teacher role

I have course edit privileges on 'Gov 2001' and 'James test course'

Courses page:

• Create New course button goes to https://booc.io/authentication/signin , whereas other buttons to which I don't have access are simply not present.
• I can create course backups for courses to which I have access, and those to which I do not.
• I tried to undo a course delete (for which I have access) through the action history, but it didn't work.
• I cannot restore courses (but this functionality is not allowed for non-admins)

Materials page:

• Create New: It appears like I can make material for courses to which I do not have edit privileges, because they appear in the list.
• Create New: If I assign material to a course to which I do not have edit privileges, then 'save' the material, the material is saved correctly. This might not actually be much of an issue, because I haven't assigned the material to any concepts.
• Edit: I can edit material assigned to courses for which I do not have edit privileges.
• Delete: I can delete material assigned to courses for which I do not have edit privileges.

A course:

• No admin tab appears for courses to which I do not have edit privileges. This works : )

Minor thing: The visual 'bar' under which the 'options' normally sit in the bottom right-hand side still appears for me even if I don't have edit privileges.

On 2 February 2016 at 19:09, Michail Schwab notifications@github.com wrote:

since this commit af6758a https://github.com/michaschwab/booc3/commit/af6758ab8972fd2ed5b38baa5c0f95ea5ea162cd content editors can also access the admin panel, but only the functions relating to the material, not the concept-changing things.

— Reply to this email directly or view it on GitHub https://github.com/michaschwab/booc3/issues/184#issuecomment-178900935.

[michaschwab]

• New Course creation should now work as teacher
• Course Delete Undo should be fixed now
• Backups: I should limit the access to the correct courses there.
• Material: yeah you currently have access to all materials. i'm not sure what's the best thing to do here. limiting access to only materials that are assigned to the course you have access to will
  • cause problems with materials that you just created without assigning them to anything?
  • disallow you from embedding contents from other courses into yours. we could just limit the association to concepts to concepts of the courses you have access to?

[jamestompkin]

This is too complex for me to talk about off the top of my head; can you try and write out the cases and diagram the possible interactions?

On 3 February 2016 at 19:59, Michail Schwab notifications@github.com wrote:

• New Course creation should now work as teacher

  Course Delete Undo should be fixed now

  Backups: I should limit the access to the correct courses there.

• Material: yeah you currently have access to all materials. i'm not sure what's the best thing to do here. limiting access to only materials that are assigned to the course you have access to will
  • cause problems with materials that you just created without assigning them to anything?
  • disallow you from embedding contents from other courses into yours. we could just limit the association to concepts to concepts of the courses you have access to?

— Reply to this email directly or view it on GitHub https://github.com/michaschwab/booc3/issues/184#issuecomment-179557559.