search

michbeck100 / pimatic-hap

Pimatic homekit bridge
GNU General Public License v2.0
30 stars 10 forks source link

add raspbee color-temperature device and raspbee multi sensor #83

Closed treban closed 4 years ago

treban commented 4 years ago

i have added the multi-sensor device from raspbee to the generic device. although contact and presence are double, but now all devices with the corresponding attributes are supported , not only if the correct template is used, like the multi-sensor device.

if this is not ok, I would create a extra accessory.

michbeck100 commented 4 years ago

Would you mind adding some tests for the generic device as well for the new device?

michbeck100 commented 4 years ago

Oh, and please fix the existing tests ;-)

treban commented 4 years ago

of course :)

treban commented 4 years ago

the checks are implemented. i have added in the generic tests all attributes which are not tested elsewhere. co2,temp,humi were already separated.

treban commented 4 years ago

the temperature test file tests the lowbattery attribute. the generic test checks the new battery attribute, which also returns a BATTERY_LEVEL_LOW at under 20%.