search

michealespinola / syno.plexupdate

A script to automagically update Plex Media Server on Synology NAS
GNU General Public License v3.0
273 stars 23 forks source link

version identification problem #10

Closed justme-1968 closed 3 years ago

justme-1968 commented 3 years ago

i just saw this and i think there might be a problem with the version identification. 

Running Ver: 1.22.2.4264-6000
 Online Ver: 1.22.2.4264-b275c4330 (Beta Channel)

and later:

Update from: 1.22.2.4264-6000
         to: 1.22.2.4264-b275c4330 failed!

i think the script is trying to install the same version again.

michealespinola commented 3 years ago

If this is what I think it is, and from what I have been told by Plex support, it's because of a recent internal numbering change made from Plex at the request of Synology in preparation for DSM7. So far this seems to particularly affect the Beta releases as also referenced in this previously reported issue:

https://github.com/michealespinola/syno.plexupdate/issues/8#issuecomment-802740585

I believe this will sort itself out after enough time has passed to push these new version numbers through.

justme-1968 commented 3 years ago

i see. but i'm not sure it will sort itself out as the reason is not a new versioning scheme but a difference in the version as seen in the file name and the version reported by the installed package from the same file. also as you can see in my example and the example from the linked thread the part after the - is identical in the reported version but different in the file name.

maybe the part after the dash should be ignored completely?

michealespinola commented 3 years ago

You're right. Thank you for engaging me about this to make me think it through. I'll have to crop the version numbers before comparing them.

michealespinola commented 3 years ago

This has been fixed in v3.0.2

justme-1968 commented 3 years ago

thanks !

michealespinola commented 3 years ago

No problem. Thank you for bringing it up and making me think about it. I didn't think it through when it was previously brought to my attention.