michealespinola / syno.plexupdate

A script to automagically update Plex Media Server on Synology NAS
GNU General Public License v3.0
273 stars 23 forks source link

Change exit status on success to 0 instead of 1 #12

Closed ghost closed 3 years ago

ghost commented 3 years ago

When setting the scheduled task to only report on error, the script still reports on success, because of the non-zero exit status when the script finishes without error. This change fixes that by changing the exit status on successful execution to 0.

ghost commented 3 years ago

Nevermind, I see this is categorized as a known non-issue. Though for those of us who do not wish to receive an email for successful executes, it is an issue. I would and have manually changed this as a workaround, but continuing to do so would mean foregoing the recent addition of the self-update, which is a shame. Therefore, I would suggest adding this as a configurable option.

michealespinola commented 3 years ago

I could make it an option to disable positive reporting of a successful update. You do not want to be notified if an update takes place?