michealespinola / syno.plexupdate

A script to automagically update Plex Media Server on Synology NAS
GNU General Public License v3.0
273 stars 23 forks source link

Don't log/email token. #39

Closed patryk closed 1 year ago

patryk commented 1 year ago

Emailing Plex Access Token is a bad security practice and should be avoided.

This PR removes printing token from emails sent.

https://cheatsheetseries.owasp.org/cheatsheets/Logging_Cheat_Sheet.html#data-to-exclude

michealespinola commented 1 year ago

Thank you for the submission and push toward best practices! I agree, and its usefulness has long since passed.

The code hasn't been submitted yet, but this logging has already been pulled from the next release. Diagnostic bits such as this have been moved into a separate supplemental script. This new diagnostic script will be located [below] when the next release is published:

Tools\syno.plexinfo.sh

Example output:


SYNO.PLEX INFO SCRIPT for DSM 7

SYNOLOGY NAS INFO:
---------------
       Nodename: HOSTNAME
        DSM ver: 7.1.1-42962 Update 3
          Model: DS1019+
   Architecture: x86_64 (apollolake)
         Kernel: Linux (4.4.180+)
  Admin account: Disabled
    Internal IP: ###.###.###.###
    External IP: ###.###.###.###

TIME ZONE INFO:
---------------
America/Los_Angeles
US/Pacific

PLEX MEDIA SERVER INFO:
---------------
  Friendly Name: Hostname
        PMS ver: 1.30.2.6563-7000
     Transcoder: ffmpeg (acf6c67-4446)
 Update Channel: Beta
      Device-ID: ###-###-###-###-###
     Machine-ID: ##########
   Online Token: ##########

PLEX DIRECTORY REFERENCE:
---------------
'/volume1/PlexMediaServer/AppData/Plex Media Server'
'/volume1/PlexMediaServer/AppData/Plex Media Server/Codecs'
'/volume1/PlexMediaServer/AppData/Plex Media Server/Codecs/acf6c67-4446-linux-x86_64'
'/volume1/PlexMediaServer/AppData/Plex Media Server/Logs'
'/volume1/PlexMediaServer/AppData/Plex Media Server/Plug-ins'
'/volume1/PlexMediaServer/AppData/Plex Media Server/Plug-in Support'
'/volume1/PlexMediaServer/AppData/Plex Media Server/Scanners'
'/volume1/PlexMediaServer/AppData/Plex Media Server/Scanners/Common'
'/volume1/PlexMediaServer/AppData/Plex Media Server/Scanners/Series'