michealespinola / syno.plexupdate

A script to automagically update Plex Media Server on Synology NAS
GNU General Public License v3.0
311 stars 24 forks source link

invalid URL if ArchFamily is like i686 #41

Closed dkweva01007 closed 1 year ago

dkweva01007 commented 1 year ago

You need to change the variable "ArchFamily" to "x86" if is egal to "i686" for the plex URL

LOG Start

SYNO.PLEX UPDATE SCRIPT v4.1.0 for DSM 7

       Script: syno.plexupdate.sh
   Script Dir: /volume1/Software/Plex/syno.plexupdate-4.1.0
  Running Ver: 4.1.0
   Online Ver: 4.1.0
     Released: 2022-07-18 19:34:39+02:00 (227+ days old)
               * No new version found.

     Synology: DS214play-j (i686), DSM 7.1.1-42962 Update 4
     Plex Dir: /volume1/PlexMediaServer/AppData/Plex Media Server
   Plex Token: ###### (NEVER POST OR SHARE THIS)
  Running Ver: 1.30.2.6563
   Online Ver: 1.31.1.6733 (Public Channel)
     Released: 2023-02-20 15:29:08+01:00 (10+ days old)
               * Newer version found!

  New Package: 
  Package Age: 10+ days old (0+ required for install)

INSTALLING NEW PACKAGE:
----------------------------------------
http://: Invalid host name.

 * Package download failed, skipping install...
----------------------------------------

  Update from: 1.30.2.6563
           to: 1.31.1.6733 succeeded!

NEW FEATURES:
----------------------------------------
* (Scanner) Adds support for the Extend multi-episode format i.e. S01E01-02 (#14064)
* (Subtitles) Attempt to automatically detect improperly-tagged forced streams based on their titles (#14096)
* (TV) Provide clients with the number of non-Specials seasons for display when browsing (#14036)
* (Web) Updated to 4.100.1
* Add Ukrainian translations.
* Updated translations.
----------------------------------------

FIXED FEATURES:
----------------------------------------
* (Clustering) Photos timeline - duplicated items or incorrect dates (#14081)
* (Credits Detection) Detection could fail with certain video codecs (#14150)
* (Credits Detection) Limit thread concurrency for first stage of detection (#14150)
* (Credits Detection) The detection could timeout and fail on low powered devices.
* (CreditsDetection) Fix assignment of `final` marker attribute (#14109)
* (Intros) Detection wouldn't proceed if background transcodes were paused (#14056)
* (Music) When shuffling smart playlists with limits, the track selection could be incorrect.
* (Transcoder) Hardware decoding using Nvidia GPUs could fail with certain driver versions (#14069) (#14070)
----------------------------------------

LOG END

if I change L.152 by

ArchFamily=$(uname --machine)
[ "$ArchFamily" = "i686" ] && ArchFamily=x86

It's work

LOG START

SYNO.PLEX UPDATE SCRIPT v4.1.0 for DSM 7

       Script: syno.plexupdate.sh
   Script Dir: /volume1/Software/Plex/syno.plexupdate-4.1.0
  Running Ver: 4.1.0
   Online Ver: 4.1.0
     Released: 2022-07-18 19:34:39+02:00 (227+ days old)
               * No new version found.

     Synology: DS214play-j (x86), DSM 7.1.1-42962 Update 4
     Plex Dir: /volume1/PlexMediaServer/AppData/Plex Media Server
   Plex Token: A2wS-pgvSn2Dt_JN1rKP (NEVER POST OR SHARE THIS)
  Running Ver: 1.30.2.6563
   Online Ver: 1.31.1.6733 (Public Channel)
     Released: 2023-02-20 15:29:08+01:00 (10+ days old)
               * Newer version found!

  New Package: PlexMediaServer-1.31.1.6733-bc0674160-x86_DSM7.spk
  Package Age: 10+ days old (0+ required for install)

INSTALLING NEW PACKAGE:
----------------------------------------
2023-03-02 21:47:50 URL:https://downloads.plex.tv/plex-media-server-new/1.31.1.6733-bc0674160/synology-dsm7/PlexMediaServer-1.31.1.6733-bc0674160-x86_DSM7.spk [97341440/97341440] -> "/volume1/Software/Plex/syno.plexupdate-4.1.0/Archive/Packages/PlexMediaServer-1.31.1.6733-bc0674160-x86_DSM7.spk" [1]
Stopping PlexMediaServer service:
{"action":"stop","beta":false,"error":{"code":0},"finished":true,"language":"enu","last_stage":"stopped","package":"PlexMediaServer","pid":29250,"scripts":[{"code":0,"message":"","type":"stop"}],"stage":"stopped","status":"stop","status_description":"translate from systemd status","success":true,"username":"","version":"1.30.2.6563-7000"}

Installing PlexMediaServer update:
{"error":{"code":0},"results":[{"action":"upgrade","beta":false,"betaIncoming":false,"error":{"code":0},"finished":true,"installReboot":false,"installing":true,"language":"enu","last_stage":"postupgrade","package":"PlexMediaServer","packageName":"Plex Media Server","pid":29436,"scripts":[{"code":0,"message":"","type":"preupgrade"},{"code":0,"message":"","type":"preuninst"},{"code":0,"message":"","type":"postuninst"},{"code":0,"message":"","type":"preinst"},{"code":0,"message":"Installation Successful!
"type":"postinst"},{"code":0,"message":"","type":"postupgrade"}],"spk":"/volume1/Software/Plex/syno.plexupdate-4.1.0/Archive/Packages/PlexMediaServer-1.31.1.6733-bc0674160-x86_DSM7.spk","stage":"installed_and_stopped","status":"stop","status_description":"translate from systemd status","success":true,"username":"","version":"1.30.2.6563-7000"}],"success":true}

Starting PlexMediaServer service:
{"action":"start","beta":false,"error":{"code":0},"finished":true,"language":"enu","last_stage":"started","package":"PlexMediaServer","pid":29908,"scripts":[{"code":0,"message":"","type":"start"}],"stage":"started","status":"running","success":true,"username":"","version":"1.31.1.6733-7000"}
----------------------------------------

  Update from: 1.30.2.6563
           to: 1.31.1.6733 succeeded!

NEW FEATURES:
----------------------------------------
* (Scanner) Adds support for the Extend multi-episode format i.e. S01E01-02 (#14064)
* (Subtitles) Attempt to automatically detect improperly-tagged forced streams based on their titles (#14096)
* (TV) Provide clients with the number of non-Specials seasons for display when browsing (#14036)
* (Web) Updated to 4.100.1
* Add Ukrainian translations.
* Updated translations.
----------------------------------------

FIXED FEATURES:
----------------------------------------
* (Clustering) Photos timeline - duplicated items or incorrect dates (#14081)
* (Credits Detection) Detection could fail with certain video codecs (#14150)
* (Credits Detection) Limit thread concurrency for first stage of detection (#14150)
* (Credits Detection) The detection could timeout and fail on low powered devices.
* (CreditsDetection) Fix assignment of `final` marker attribute (#14109)
* (Intros) Detection wouldn't proceed if background transcodes were paused (#14056)
* (Music) When shuffling smart playlists with limits, the track selection could be incorrect.
* (Transcoder) Hardware decoding using Nvidia GPUs could fail with certain driver versions (#14069) (#14070)
----------------------------------------

LOG END

michealespinola commented 1 year ago

I'm not sure I understand. That code is already present in v4.1.0:

https://github.com/michealespinola/syno.plexupdate/blob/master/syno.plexupdate.sh#L151-L154

What is it that you changed to make it work for you?

dkweva01007 commented 1 year ago

Hi, ok it's already present in the master but not in the V4.1.0. You update script will only update with the release tag but not with the master branch.

You need to create a new tag version.

michealespinola commented 1 year ago

Oh my goodness, I had thought that code had made it into v4.1.0! Thank you for bringing that to my attention. I will make a new release shortly.