search

michealespinola / syno.plexupdate

A script to automagically update Plex Media Server on Synology NAS
GNU General Public License v3.0
273 stars 23 forks source link

send notification only if there was any update #9

Closed justme-1968 closed 3 years ago

justme-1968 commented 3 years ago

just found your script and i love it. two suggestion though:

thanks andre

michealespinola commented 3 years ago

Notifications are only triggered on an actual update installation attempt (success or fail).

I'm not certain what you mean by the "plex push notification"

justme-1968 commented 3 years ago

ok.. i think the task should be configured to send e-mails only if there was an 'error' and the script will trigger an 'error' if it wants to send the message.

this should probably mentioned in the installation instructions.

since a few weeks plex has the ability to send push notifications to mobile clients. see here: https://support.plex.tv/articles/push-notifications/

it would be great if you could figure out how to trigger such a notification from your script instead or in addition to the e-mail from the synology automation system.

michealespinola commented 3 years ago

There arent any tools I am aware of that I could utilize via bash/DSM to trigger a built-in Plex notification.

I'm otherwise unsure of what kind of message you want triggered. Are you saying that you only want errors, and not be notified of successful version updates?

justme-1968 commented 3 years ago

regarding 1.: no. its fine now. the only thing i wanted was to get no notification if nothing has changed and there was no error. you are already taking care of this but maybe you should clarify it in the install instructions.

regarding 2.: maybe that could be asked in the plex forum

michealespinola commented 3 years ago

It only notifies if the condition to update is met (newer version and age requirement) and an update attempt succeeded or failed. Otherwise, there are no notifications no matter how often it is run. Even if a new update is available - an install is not attempted and you will not receive any notifications if it doesn't meet the age requirement and an install is actually attempted.

I'll add a more clear description of notifications to the docs.

Feel free to shag that question to them. If it can be done completely native to the Synology DSM with bash, I'll add it.

justme-1968 commented 3 years ago

just did so here: https://forums.plex.tv/t/trigger-push-notifications-api/705881