search

micheldoumit / tripvise

0 stars 0 forks source link

DRY #21

Closed basmoura closed 9 years ago

basmoura commented 9 years ago

Seguindo o padrão do Rails, os métodos 'trip = Trip.find_by(id: code.trip_id)' e 'code = Code.find_by(code: params[:trip_code])' poderiam estar em um método privado e ser chamado no before_action :method, only: [:send_email, :redee] :nail_care:

commit file reference
cfd2fee94fd6c0c1591bfbf1433d4669a10bf81f app/controllers/users_controller.rb#L1 #15
marciotoze commented 9 years ago

:+1:

na verdade tem find_by desnecessário ai :curly_loop:...

  def send_email
    ...
    trip = code.trip
    ...
  end
basmoura commented 9 years ago

:+1: