micheldoumit / tripvise

0 stars 0 forks source link

Apple rejeitou binary por 2 razoes #58

Closed dglmartins closed 9 years ago

dglmartins commented 9 years ago

From Apple 17.2 - Apps that require users to share personal information, such as email address and date of birth, in order to function will be rejected Program License Agreement

17.2 Details

We noticed that your app uses Facebook login for authentication purposes but does not include account-based features offered by that site, which is not allowed on the App Store.

Next Steps

Please modify your app to include account-based features of that social network or use your own authentication mechanism.

PLA 3.3.12

We also found that your app uses the iOS Advertising Identifier but does not include ad functionality. This does not comply with the terms of the iOS Developer Program License Agreement, as required by the App Store Review Guidelines.

Specifically, section 3.3.12 of the iOS Developer Program License Agreement states:

"You and Your Applications (and any third party with whom you have contracted to serve advertising) may use the Advertising Identifier, and any information obtained through the use of the Advertising Identifier, only for the purpose of serving advertising. If a user resets the Advertising Identifier, then You agree not to combine, correlate, link or otherwise associate, either directly or indirectly, the prior Advertising Identifier and any derived information with the reset Advertising Identifier."

Note: iAd does not use the AdSupport framework, ASIdentifierManager, or the Advertising Identifier. Therefore they are not required for iAd implementations and should not be included in your app for iAd support.

If your app is serving ads, please:

If your app does not serve ads, please check your code - including any third-party libraries - to remove any instances of:

class: ASIdentifierManager
selector: advertisingIdentifier
framework: AdSupport.framework

If you are planning to incorporate ads in a future version, please remove the Advertising Identifier from your app until you have included ad functionality.

To help locate the Advertising Identifier, use the “nm” tool. For information on the “nm” tool, please see the nm man page.

If you do not have access to the libraries' source, you may be able to search the compiled binary using the "strings" or "otool" command line tools. The "strings" tool lists the methods that the library calls, and "otool -ov" will list the Objective-C class structures and their defined methods. These techniques can help you narrow down where the problematic code resides.

AI TEM UM SCREESHOT DA NOSSA TELA DO LOGIN

dglmartins commented 9 years ago

Respondi com isso, talvez vamos ter q add o "ask a FB friend" feature

Hi, Please be aware that we already do use Facebook features in our app: First, we allow users to share their trip to Facebook after it has been created. Secondly, the app only allows friends to receive recommendations from Facebook friends. For example, if I have a trip and you try to add my trip code to give me recommendations and are not my Facebook friend, our app will tell you that you have to be my friend to see my trip. Please let me know if this solves the issue or if we have to add more Facebook features to the app to comply. For the advertising ID, we will fix the issue. Looking forward to your response.

dglmartins commented 9 years ago

Fiz um research online e aparentemente eles acham que o nosso app nao tem feature do Facebook, entao que o metodo de autenticacao de login com Facebook não é correto na visão deles. Eles querem que a gente adicione algum outro Facebook feature ou mude pra um metodo de autenticacao proprio. Obviamente nosso app depende do FB e mudar pra um autenticação próprio não é uma opcao. Eu mandei a mensagem acima explicando que o app já tem features de interação com a conta dos usuarios do Facebook, inclusive o post to wall, e a foto do profile.

De qualquer forma, acho que a gente já devia voltar o feature do botao "Ask your Facebook Friends" (na pagina de congratulations) que já esta praticamente pronto e a gente tirou, arrumar o negocio do advertising id q tb ta errado e resubmit, ao invés de ficar discutindo com eles.

Só que pra adicionar esse feature de perguntar direto via o app pra FB friend que já usa, precisaria de um notificação por email te avisando quando alguém te pede recomendação. Pq a trip simplesmente aparece do nada no My Friends' Request e ninguém vai nem saber. Um email igual o que já tem quando alguém responde, mas pra quando alguém pede recomendacao via o feature. Algo como "Danilo has asked for your recommendation for an upcoming trip. You can find Danilo's trip and add your recommendations under My Friends' Requests in the Tripvise.me app" @MarcusSky se a Dany adicionar o feature no app, vc faz o esquema pra mandar esse email de notificação quando alguém usa o feature pra perguntar? @DanielyBotelho Se formos adicionar esse feature, eu queria que quando ainda não tivesse nenhum amigo no app tivesse uma mensagem :"Tripvise.me is a new app. None of your Facebook friends have joined yet. You can still ask your friends for recommendations by sending them your trip code", com aquela fonte giz branco? Me avisem o que vcs acham. Danilo

dglmartins commented 9 years ago

@MarcusSky @DanielyBotelho a Apple respondeu hoje de manhã, vamos esperar então:

Hello,

Thank you for your response and clarification. We apologize for the delay. Your application is still in review but is requiring additional time. We will provide further status as soon as we are able. Thank you for your continued patience.

Best regards,

dglmartins commented 9 years ago

@MarcusSky @DanielyBotelho Mensagem nova, Uhuuu! Agora só corrigir o advertising id e resubmit:

Hi again,

Thank you for your response and clarification. After further review and consideration we have found that your application is in compliance with the 17.2 guideline.

We appreciate your attention to the PLA 3.3.12 issue and we look forward to reviewing your revised app.

Best regards,

App Store Review

MarcusSky commented 9 years ago

@dglmartins aeeee, legal! @DanielyBotelho, se precisar de ajuda me avisa :+1: