search

micheleangioni / laravel-js-lang-converter

Laravel lang files conversion to Javacript
MIT License
25 stars 8 forks source link

All locales plural forms added #2

Closed antonkomarev closed 8 years ago

antonkomarev commented 8 years ago

Full description of PR in issue #1

micheleangioni commented 8 years ago

Mmmh interesting, so if I understand well, in some languages count == 1 and count > 1 are not the only possibilities?

However, all european languages (English, Italian, Spanish, French etc.) should have

return (count == 1) ? 0 : 1;

in thier cases in the switch. Are you sure the wa, uk, sk, ga, lt etc.. cases are correct?

antonkomarev commented 8 years ago

@micheleangioni you can re-check it yourself. I've just transformed Laravel's code to Javascript.

In Russian language there are 1 singular form and +2 plural forms. In Arabic language even more.

uk locale is Ukrainian and as I know it's pretty close to Russian.

micheleangioni commented 8 years ago

Ok @a-komarev , I'll work on that in the following days!