search

micheleangioni / laravel-js-lang-converter

Laravel lang files conversion to Javacript
MIT License
25 stars 8 forks source link

Pluralizations are per-language, while translation strings are per-locale, so isolating per-language logic to _getPluralForm #6

Closed matthew-sycle closed 8 years ago

matthew-sycle commented 8 years ago

The latest change was still broken: When the Locale is changed to "en" from "en_US", it could not find any of the translations, as they are keyed per-locale.

The rest of the translation logic should be locale-specific, it is only the pluralization logic which is language-specific.

micheleangioni commented 8 years ago

@matthew-sycle yeah, this is a better approach. Thanks for your contribution.