Use TypeScript and add Gnome 46 support

micheledaros / gnome-shell-extension-simulate-switching-workspaces-on-active-monitor

MIT License

24 stars 4 forks source link

Use TypeScript and add Gnome 46 support #8

Closed ProbstDJakob closed 3 months ago

ProbstDJakob commented 4 months ago

In order to make further development for new contributors easier I've added TypeScript support since it is now officially supported. This will also help migrating the extension to new Gnome versions in the future. Furthermore I checked if it works on Gnome 46 and added it to the metadata.json.

Changes made besides adding simple types:

remove the use of global variables and move them into the SwitchWorkspacesExtension class
use an enum for the constants UPand DOWN (behaves the same as the numbers with the benefit for restricting the values)
use a container to encapsulate the warning menu variables since they share the same lifetime and thus only one variable needs to be checked if it is null
use the private visibility modifier instead of underscores
move the constants of ConfigurationService out of the class and make them real constants

ProbstDJakob commented 4 months ago

It would be nice if the issues section would be enabled in order to discuss such changes before implementing them and also this would make it possible to create bug reports and feature requests which other contributors could then fix/implement.

cmdillon commented 3 months ago

hi! i noticed you are working on updating this extension. is it ready for gnome 46? really would like to give it a try as the original only works on gnome 45.

ProbstDJakob commented 3 months ago

The extension works without any changes to the code with Gnome 46. The only thing which really had to be done is to add Gnome 46 to the metadata.json. These changes are primarily meant to provide an easier way to migrate to upcoming Gnome versions which may involve breaking changes to the APIs used.

If you want to use this extension with Gnome 46, you could go to the terminal and enter the following Command. This will skip the version checks and thus enables the (all) extension even though it officially does not support it.

$ gsettings set org.gnome.shell disable-extension-version-validation true

micheledaros commented 3 months ago

It would be nice if the issues section would be enabled in order to discuss such changes before implementing them and also this would make it possible to create bug reports and feature requests which other contributors could then fix/implement.

good idea, I've just done it