micheleg / dash-to-dock

A dock for the Gnome Shell. This extension moves the dash out of the overview transforming it in a dock for an easier launching of applications and a faster switching between windows and desktops.
https://micheleg.github.io/dash-to-dock/
GNU General Public License v2.0
3.85k stars 462 forks source link

Duplicate first key stroke on activities overview #1855

Open ndfsa opened 1 year ago

ndfsa commented 1 year ago

Since extensions.gnome.org-v75 when using the "Type to search" box on the activities overview, the first keystroke is duplicated.

Steps to reproduce:

  1. Press super key to show activities overview.
  2. Start typing without clicking the "Type to search" text box

Expected behavior: The text typed appears in the "Type to search" text box Actual behavior: The text typed appears in the "Type to search" text box with the first letter repeated. e.g. (tterm when typing term)

I found a workaround to temporarily make the issue go away, but on logout or restart it comes back.

  1. Turn off extension from "Extensions" gnome app
  2. Restart Gnome shell (Alt + F2 r Enter)
  3. Turn on extension from "Extensions" gnome app

Information about system: GNOME Shell 42.5 (Xorg) Arch Linux Nvidia driver nvidia-520.56.06-3

ndfsa commented 1 year ago

Did a git bisect from v74 to v75 and it appears that the offending commit is 8e4f4a8

vanvugt commented 1 year ago

That commit sounds like a red herring. I think the issue is much older than that: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4651

sbstnk commented 1 year ago

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2514 might be helpful to track this down

kedicchi commented 1 year ago

got the same problem. really annoying. switched to cosmic till its fixed

LautiLosio commented 1 year ago

I had the same problem, a reinstall with a reboot in between fixed it. Let's see how long it lasts...

NateNate60 commented 1 year ago

I have a video of the issue. It seems to not occur when you click on the search bar first before typing:

bug-2022-10-18_19 06 36

roworu commented 1 year ago

I'm also having this issue. Fixed with rollback to v74

sbstnk commented 1 year ago

Looks like one of the signal handlers here can be called while there is already a startup animation running. So the normal startup animation is running, the overview is in the showing transition state and the first showing signal has already been emitted. Then the signal handler calls Main.overview.runStartupAnimation again, which emits the second showing signal, giving us the two consecutive showing signals without any intermediate hiding signal, which is enough to trigger the issue.

That's however only based on looking at the code since I'm still not able to reproduce the issue myself.

sbstnk commented 1 year ago

Managed to reproduce this now by triggering a monitor configuration change during startup. I had to plug in a second monitor during startup to trigger this, but I guess depending on the hardware/configuration this could just happen without requiring this kind of manual interference.

The monitors-changed signal during startup then triggers DockManager::_toggle(), which, like already suspected, ends up calling Main.overview.runStartupAnimation() triggering the second showing signal. That then triggers the issue, because the SearchController connects to stage keypress events when the overview starts showing and disconnects when it is hiding (so it can capture key presses even when not focused).

pgassmann commented 1 year ago

@roworu how can I downgrade the extension? Do I need to build it from sources? I'm having the issue on Ubuntu 22.04. Is there a way to reset to the version from the OS?

ndfsa commented 1 year ago

@pgassmann you can build from source on the v74 branch, then change the version to "75" on the metadata.json file to prevent gnome extensions from automatically updating your extension for the time being, don't forget to change it back when you no longer need v74.

ncounter commented 1 year ago

Workaround: there is a flag option under Appearance that says Show overview on startup. By disabling it and re-logging back, it does not happen anymore, and the drawback is only that it does not trigger the overview view at startup. I'm using dash to dock v75

techgasp commented 1 year ago

Confirmed Debian Testing/Bookworm "Type to search" box on the activities overview, the first keystroke is duplicated. Kernel 6.0.0-2-amd64 Nvidia 510.85.02 GNOME Shell 43.0 dash to dock v75

porl commented 1 year ago

Can confirm ncounter's workaround solved the issue for me.

arahiko-ayami commented 1 year ago

I tried ncounter's solution and it worked! Another thing you can try is use Dash to dock for COSMIC as a temporary replacement

Ray-Eldath commented 1 year ago

Workaround: there is a flag option under Appearance that says Show overview on startup. By disabling it and re-logging back, it does not happen anymore, and the drawback is only that it does not trigger the overview view at startup. I'm using dash to dock v75

FYI re-logging is not needed, just hit Alt + F2 then type r and Enter to restart the gnome-shell could fix things.

kostas-theo commented 1 year ago

Thanks for the workaround @ncounter - for some reason I don't see "Show overview on startup" anywhere :S

would you perhaps knows the gsettings schema / key for the that setting?

ncounter commented 1 year ago

Thanks for the workaround @ncounter - for some reason I don't see "Show overview on startup" anywhere :S

would you perhaps knows the gsettings schema / key for the that setting?

@kostas-theo it should be disable-overview-on-startup, it is set to false by default so you should set it to true, like the following:

gsettings set org.gnome.shell.extensions.dash-to-dock disable-overview-on-startup true

or

dconf write /org/gnome/shell/extensions/dash-to-dock/disable-overview-on-startup true

In the UI it works like the opposite logic because there is a reverse setting here Screenshot from 2022-11-08 16-12-58

cfcosta commented 1 year ago
dconf write /org/gnome/shell/extensions/dash-to-dock/disable-overview-on-startup true

This worked for me.

EdanBrooke commented 1 year ago

Workaround: there is a flag option under Appearance that says Show overview on startup. By disabling it and re-logging back, it does not happen anymore, and the drawback is only that it does not trigger the overview view at startup. I'm using dash to dock v75

Thank you very much. Worked for me too on Manjaro with GNOME.

I'd been having issues with my wireless keyboard and repeating keystrokes and thought it was the same issue with my replacement keyboard, but noticed it only happened on the search in the Activities view. This has fixed it and I didn't like it showing the overview anyway, so two birds with one stone.

MartinVonReichenberg commented 1 year ago

Confirming on the latest openSUSE Tumbleweed 14.11.2022 with GNOME 43.1 on X11 Using HOT Corner and typing the 'desired' letter straight away duplicates it . . .

             .;ldkO0000Okdl;.                martin@nvisen-minipc--opensuse-tumbleweed
         .;d00xl:^''''''^:ok00d;.            OS: openSUSE 20221114
       .d00l'                'o00d.          Kernel: x86_64 Linux 6.0.8-1-default
     .d0K^'  Okxoc;:,.          ^O0d.        Uptime: 52m
    .OVVAK0kOKKKKKKKKKKOxo:,      lKO.       Packages: 2766
   ,0VVAKKKKKKKKKKKKK0P^,,,^dx:    ;00,      Shell: fish 3.5.1
  .OVVAKKKKKKKKKKKKKk'.oOPPb.'0k.   cKO.     Resolution: 1920x1080
  :KVAKKKKKKKKKKKKKK: kKx..dd lKd   'OK:     DE: GNOME 43.1
  lKlKKKKKKKKKOx0KKKd ^0KKKO' kKKc   lKl     WM: Mutter
  lKlKKKKKKKKKK;.;oOKx,..^..;kKKK0.  lKl     WM Theme: Adwaita
  :KAlKKKKKKKKK0o;...^cdxxOK0O/^^'  .0K:     GTK Theme: Adwaita [GTK2/3]
   kKAVKKKKKKKKKKKK0x;,,......,;od  lKP      Icon Theme: Adwaita
   '0KAVKKKKKKKKKKKKKKKKKK00KKOo^  c00'      Font: Roboto 11
    'kKAVOxddxkOO00000Okxoc;''   .dKV'       Disk: 1.1T / 4.8T (24%)
      l0Ko.                    .c00l'        CPU: Intel Core i7-1065G7 @ 8x 3.9GHz [57.0°C]
       'l0Kk:.              .;xK0l'          GPU: Mesa Intel(R) Iris(R) Plus Graphics (ICL GT2)
          'lkK0xc;:,,,,:;odO0kl'             RAM: 3684MiB / 15510MiB
              '^:ldxkkkkxdl:^'  

Screenshot from 2022-11-16 11-39-10 Screenshot from 2022-11-16 11-39-39

human3rr commented 1 year ago
dconf write /org/gnome/shell/extensions/dash-to-dock/disable-overview-on-startup true

This worked for me.

Same

4sa617 commented 1 year ago

dconf write /org/gnome/shell/extensions/dash-to-dock/disable-overview-on-startup true

Worked for me as well! Glad to have Dash to Dock Back!

ErrorNoInternet commented 1 year ago

If someone else's solution works, just react to their message with a 👍 emoji or something. No need to send a whole new comment just to say that it works and eventually fill up the screen :)

lamnguyenvu98 commented 1 year ago

The same issue happened to me when I switched to Xorg. On Wayland, everything was totally normal. I use Manjaro Gnome, Gnome version 43.1.

MartinVonReichenberg commented 1 year ago

The same issue happened to me when I switched to Xorg. On Wayland, everything was totally normal. I use Manjaro Gnome, Gnome version 43.1.

""Totally"" Normal

meyersbs commented 1 year ago

Also happening on RHEL9. Will test workaround soon.

Details:

Neo-29 commented 1 year ago

Same here

Workaround above with dconf working

bshor commented 1 year ago

Same bug with the same setup as @Neo-29 but the dconf workaround doesn't help. Still get the doubled letters.

Neo-29 commented 1 year ago

Same bug with the same setup as @Neo-29 but the dconf workaround doesn't help. Still get the doubled letters.

Can come back. But the workaround workks. Check if an extension doesn't interfer with it.

bshor commented 1 year ago

Which other extension might be interfering?

Neo-29 commented 1 year ago

Which other extension might be interfering?

Just perfection for example. Opt in or out in settings for overview. Desktop - overview

crantisz1 commented 1 year ago

downgraded to 74, works fine now

stuarthayhurst commented 1 year ago

Is this related to https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2667 at all? That MR links to an issue discussing this one.

sbstnk commented 1 year ago

No, it's not related. The issue on the GNOME gitlab also is not really about this issue here.

It is somewhat related to https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2514 which has been merged in 43.3. With that MR this bug should now trigger an error message during startup rather than causing duplicate characters when searching.

That error message should have a backtrace that basically points to the bug in dash-to-dock as already described in https://github.com/micheleg/dash-to-dock/issues/1855#issuecomment-1287402129.

vanvugt commented 1 year ago

Downstream Ubuntu bug: https://launchpad.net/bugs/1956248

luismejia1 commented 1 year ago

Thanks for the workaround @ncounter - for some reason I don't see "Show overview on startup" anywhere :S would you perhaps knows the gsettings schema / key for the that setting?

@kostas-theo it should be disable-overview-on-startup, it is set to false by default so you should set it to true, like the following:

gsettings set org.gnome.shell.extensions.dash-to-dock disable-overview-on-startup true

or

dconf write /org/gnome/shell/extensions/dash-to-dock/disable-overview-on-startup true

In the UI it works like the opposite logic because there is a reverse setting here Screenshot from 2022-11-08 16-12-58

bro, thanks, this dconf write /org/gnome/shell/extensions/dash-to-dock/disable-overview-on-startup true work for me.