micheleg / dash-to-dock

A dock for the Gnome Shell. This extension moves the dash out of the overview transforming it in a dock for an easier launching of applications and a faster switching between windows and desktops.
https://micheleg.github.io/dash-to-dock/
GNU General Public License v2.0
3.83k stars 464 forks source link

Error on disabling extension in DesktopIcons Integration #2073

Closed smedir closed 11 months ago

smedir commented 11 months ago

https://github.com/micheleg/dash-to-dock/blob/71189a9fcc62a73f50add8a99baaeb6256ac9b68/desktopIconsIntegration.js#L161

Aug 17 06:20:23 archlinux gnome-shell[4514]: JS ERROR: TypeError: DockManager.getDefault() is null get extension@file:///home/x/.local/share/gnome-shell/extensions/dash-to-dock@micxgx.gmail.com/docking.js:1719:28 _sendMarginsToExtension@file:///home/x/.local/share/gnome-shell/extensions/dash-to-dock@micxgx.gmail.com/desktopIconsIntegration.js:161:1 _sendMarginsToAll/<@file:///home/x/.local/share/gnome-shell/extensions/dash-to-dock@micxgx.gmail.com/desktopIconsIntegration.js:149:18 _sendMarginsToAll@file:///home/x/.local/share/gnome-shell/extensions/dash-to-dock@micxgx.gmail.com/desktopIconsIntegration.js:148:43 _changedMargins/this._timedMarginsID<@file:///home/x/.local/share/gnome-shell/extensions/dash-to-dock@micxgx.gmail.com/desktopIconsIntegration.js:141:18 @resource:///org/gnome/shell/ui/init.js:21:20

vanvugt commented 11 months ago

Duplicate of #1444

smedir commented 11 months ago

Not just duplicate, need to use https://gitlab.com/smedius/desktop-icons-ng/-/blob/main/desktopIconsIntegration.js?ref_type=heads, updated file.

Initiate DestopIocnsIntegraton with DesktopIconsIntegration.DesktopIconsUsableAreaClass(DockManager.getDefault) instead... OR the directly the uuid of the extension.