search

micheleg / dash-to-dock

A dock for the Gnome Shell. This extension moves the dash out of the overview transforming it in a dock for an easier launching of applications and a faster switching between windows and desktops.
https://micheleg.github.io/dash-to-dock/
GNU General Public License v2.0
3.87k stars 461 forks source link

Minimizing apps running on XWayland leads to strange animation #2085

Open astrocaat opened 1 year ago

astrocaat commented 1 year ago

The minimizing animation works as intended with any GTK app I tested. I have some Electron and QT ones (Telegram, Spotify, Notion, etc.) and with those there is some kind of artifact when minimizing which leads the app to both go down in the dock and at the same time up in the hot corner of Activities.

Some screenshots where you can see the strange behaviour of the minimizing window:

Screenshot from 2023-08-28 17-44-31 Screenshot from 2023-08-29 10-53-10

i'm on ArchLinux with GNOME 45 and Dash-to-dock v87.

vanvugt commented 1 year ago

Please:

  1. Attach a recording or video of the bug.
  2. Check that the same bug does not occur without the extension.
astrocaat commented 1 year ago

The bug does not occur without the extension and I do not have any other installed besides Dash-to-dock. When minimizing windows, they correctly and smoothly minimize in the hot corner of Activities (instead of going down, as there is no dock). After enabling the extension, the bug starts occuring and windows get minimized both up in corner and down in dock.

GNOME’s built-in videorecording does not work for me in a Wayland session, so I switched to X11 and strangely I noticed that there the bug occurs also with GTK apps (on Wayland GTK ones all minimize correctly down in the dock without that animation artifact).

screencast-from-2023-08-30-15-35-22.webm

vageliskatsiotis commented 1 year ago

Confirming this on Arch with Deluge too.

taoky commented 1 year ago

GNOME’s built-in videorecording does not work for me in a Wayland session, so I switched to X11 and strangely I noticed that there the bug occurs also with GTK apps (on Wayland GTK ones all minimize correctly down in the dock without that animation artifact). screencast-from-2023-08-30-15-35-22.webm

This screen recording looks like https://github.com/micheleg/dash-to-dock/issues/1881 and my MR to gnome-shell (https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2968) might solve (or workaround maybe?) this animation issue. Though I cannot reproduce "minimizing which leads the app to both go down in the dock and at the same time up in the hot corner of Activities" in my testing env...

vanvugt commented 1 year ago

We're tracking this bug in https://gitlab.gnome.org/GNOME/mutter/-/issues/2317 - I don't think it's a dash-to-dock bug. Although dock extensions do change the minimize destination so it may be a factor in triggering the bug.

astrocaat commented 11 months ago

I wanna add that I found out I was wrong about the GTK vs Electron/Qt apps thing. Even if it seemed to be the case, it's simply a matter of Wayland vs XWayland: apps running on the former animate correctly while they have that bug on the latter. Most if not all GTK apps run natively on Wayland and that's why they didn't seem to be affected. As a matter of fact, lunching Electron apps with --enable-features=UseOzonePlatform --ozone-platform=wayland flags solved the issue for me.

muhammad-halimov commented 8 months ago

This strange behavior of windows still not fixed or i didn't find any solution maybe... ? Anyway there's decent solution for this, https://extensions.gnome.org/extension/1680/animation-tweaks/, install this extension and enjoy your life, of course set it up for your pleasure, there's tons of animations.

taoky commented 8 months ago

This strange behavior of windows still not fixed or i didn't find any solution maybe... ? Anyway there's decent solution for this, https://extensions.gnome.org/extension/1680/animation-tweaks/, install this extension and enjoy your life, of course set it up for your pleasure, there's tons of animations.

It's impossible to disable minimize animation while not affecting others in GNOME 45, as it adopts ESM modules for extensions, and thus not allowing overriding the constant controlling minimization speed.