search

micheleg / dash-to-dock

A dock for the Gnome Shell. This extension moves the dash out of the overview transforming it in a dock for an easier launching of applications and a faster switching between windows and desktops.
https://micheleg.github.io/dash-to-dock/
GNU General Public License v2.0
3.87k stars 461 forks source link

Support plural forms for translation ("Quit %d Windows" string) #2100

Closed xalt7x closed 11 months ago

xalt7x commented 12 months ago

In appIcons.js there's a code which adds taskbar action to Quit applications/windows:

        if (this._source.windowsCount > 0) {
            if (this._source.windowsCount === 1) {
                this._quitMenuItem.label.set_text(_('Quit'));
            } else {
                this._quitMenuItem.label.set_text(__('Quit %d Windows').format(
                    this._source.windowsCount));
            }

Which leaves only one form of plural from translators:

msgid "Quit %d Windows"

For languages like Ukrainian (which can use 3 plural forms), it's impossible to translate this string correctly, covering all possible numbers of windows.

Please add support for the plural forms of this string.

Thanks.

3v1n0 commented 12 months ago

Please check if https://github.com/micheleg/dash-to-dock/pull/2102 helps with this