search

micheleg / dash-to-dock

A dock for the Gnome Shell. This extension moves the dash out of the overview transforming it in a dock for an easier launching of applications and a faster switching between windows and desktops.
https://micheleg.github.io/dash-to-dock/
GNU General Public License v2.0
3.82k stars 463 forks source link

Fix dockmanager null #2148

Closed smedir closed 3 months ago

smedir commented 4 months ago

Dockmanager can be null, and this spams the log if desktopIconsIntegration class is initialized and used.

Dec 11: JS ERROR: TypeError: DockManager.getDefault() is null get extension@file:///home//.local/share/gnome-shell/extensions/dash-to-dock@micxgx.gmai> _sendMarginsToExtension@file:///home//.local/share/gnome-shell/extensions/dash-to-dock@m> _sendMarginsToAll/@file:///home/*/.local/share/gnome-shell/extensions/dash-to-dock@micxg _sendMarginsToAll@file:///home//.local/share/gnome-shell/extensions/dash-to-dock@micxgx.> _changedMargins/this._timedMarginsID<@file:///home//.local/share/gnome-shell/extensions/> @resource:///org/gnome/shell/ui/init.js:21:20

desktopIconsIntegration class is initialized and called from the extension and really should not have any other dependencies other than the shell, it is meant to be used and can be used as is by any extension if called as is independently without modifications.

sergio-costas commented 4 months ago

@3v1n0 Can you review this, please? I think it's a good idea to merge it.

smedir commented 3 months ago

Please also see previous MR #2132

vanvugt commented 3 months ago

Sounds like this should close https://github.com/micheleg/dash-to-dock/issues/1444

sergio-costas commented 3 months ago

@vanvugt I don't have permissions to merge here. Can you do it, please?

vanvugt commented 3 months ago

I was waiting for us to complete #2146 first, just in case this caused unnecessary conflicts.