micheleg / dash-to-dock

A dock for the Gnome Shell. This extension moves the dash out of the overview transforming it in a dock for an easier launching of applications and a faster switching between windows and desktops.
https://micheleg.github.io/dash-to-dock/
GNU General Public License v2.0
3.82k stars 463 forks source link

Dot indicators appear on top of icons in GNOME 46 #2160

Closed vanvugt closed 3 months ago

vanvugt commented 3 months ago

Dot indicators appear on top of icons in GNOME 46:

Screenshot from 2024-03-19 15-42-55

a1ex-ak commented 3 months ago

if you set "Use built-in theme" in the settings, then the point returns to its place. Снимок экрана от 2024-03-20 13-19-08

garrett commented 3 months ago

If you don't choose "built-in theme", but change from "Default" to "Dots", it gets less wrong.

Here's built-in off with "default" on:

image

image

And with "dots on:

image

image

Dots is basically the same as built-in theme. Here's built-in theme as a comparison:

image

The dots look fine on most icons, but are incorrect on chunkier icons like all the chat apps. In other words, I'd say it's always wrong (as the indicator shouldn't touch the icons), but it's less wrong with dots or built-in.

vanvugt commented 3 months ago

Judging from those screenshots, I think my first one at the top of the page looks worst (most overlapped) because I'm using display scale 200%. So https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7488 is a little bit of a factor here. I guess we can avoid getting confused with that bug by testing with display scale 100% first.

Calosis commented 3 months ago

Judging from those screenshots, I think my first one at the top of the page looks worst (most overlapped) because I'm using display scale 200%. So https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7488 is a little bit of a factor here. I guess we can avoid getting confused with that bug by testing with display scale 100% first.

It's happening to me on a 1920x1080 screen, 100% scaling.

gnolooo commented 3 months ago

I'm facing similar issues. I'm experiencing the dots issue as well. However, both "Use built-in theme" or "Default" (instead of "Dots") options don't work for me: whenever I set them, the dots just completely disappear.

Also, now icons are much smaller and with less padding (so they appear more compact). I had to significantly increase the icon size to get something visually similar to before, but they're still too tight (in my opinion). For this reason, the icons no longer have the old overlay when hovering with the cursor, but now they have a much smaller and square overlay. Weirdly, the only icon that has the same padding and same overlay, is the applications icon. More in the pictures below.

Here you can see the applications icon, with same old padding and overlay:

Schermata del 2024-03-26 13-56-25

Here you can see other icons with square overlay and much less padding:

Schermata del 2024-03-26 13-56-49

For reference, this is what the old, beautiful dock used to look like (you can clearly see much more padding, correctly placed dots, big and rounded overlays etc):

Old-dock

Hope I explained myself.

gnolooo commented 3 months ago

I can confirm this merge does absolutely nothing for me. I still have the issues I posted yesterday above.

vanvugt commented 3 months ago

I can confirm this merge does absolutely nothing for me. I still have the issues I posted yesterday above.

That's a subtly different bug being tracked upstream. If the proposed fix doesn't work for you then please open a new dash-to-dock bug.

gnolooo commented 3 months ago

What about the padding issue? The spacing between app icons, which results in a too compact view. Is it related to the upstream bug, or should I open a new issue here?

vanvugt commented 3 months ago

What about the padding issue? The spacing between app icons, which results in a too compact view. Is it related to the upstream bug, or should I open a new issue here?

That sounds like a whole new bug so please open a new issue about it. Also sounds like #844 is no longer true.