Fix dot height in default mode

micheleg / dash-to-dock

A dock for the Gnome Shell. This extension moves the dash out of the overview transforming it in a dock for an easier launching of applications and a faster switching between windows and desktops.

https://micheleg.github.io/dash-to-dock/

GNU General Public License v2.0

3.82k stars 463 forks source link

Fix dot height in default mode #2168

Closed sergio-costas closed 3 months ago

sergio-costas commented 3 months ago

Fix https://github.com/micheleg/dash-to-dock/issues/2160

sergio-costas commented 3 months ago

@vanvugt Fixed the dot height in Gnome 46, and confirmed that it doesn't break in Gnome 45.

vanvugt commented 3 months ago

Thanks. Testing it I see the dot is still too close to the icon. And reverting to scale 100% doesn't totally fix that.

Can you check to see how upstream does their spacing?

vanvugt commented 3 months ago

Maybe fixing https://github.com/micheleg/dash-to-dock/issues/2173 would change things? Or maybe it's not related.

sergio-costas commented 3 months ago

I see the dot exactly in the same place than in gnome 45...

Gnome45: Captura desde 2024-03-25 16-55-50

Gnome46: imagen

sergio-costas commented 3 months ago

But, of course, I don't use scaling... At which scale are you using your desktop? How can I take into account scaling in CSS?

3v1n0 commented 3 months ago

How can I take into account scaling in CSS?

Css should handle it automatically.

You can simulate scaling in a nested GNOME shell easily though. Launches it with something like MUTTER_DEBUG_DUMMY_MONITOR_SCALES=1 and MUTTER_DEBUG_DUMMY_MODE_SPECS="1920x1080:3840x2160:4096x2160:7680x4320:3840x2400:3200x1800:2650x1440:1024x768:800x600:1440x900:1680x1050:1680x1012"

vanvugt commented 3 months ago

I see the dot exactly in the same place than in gnome 45...

Gnome45:

Gnome46:

That's not a good example because they are different icons (one's not square). Also the dot is touching the bottom in the second screenshot, but not the first. But all this may be off-topic so I'll take new screenshots...

vanvugt commented 3 months ago

OK my main concern is only visible at 200% today:

gnome-shell	#2168