search

micheleg / dash-to-dock

A dock for the Gnome Shell. This extension moves the dash out of the overview transforming it in a dock for an easier launching of applications and a faster switching between windows and desktops.
https://micheleg.github.io/dash-to-dock/
GNU General Public License v2.0
3.82k stars 463 forks source link

fix deprecated "St.ScrollView.[hv]scroll" property #2185

Closed K1ngjulien closed 3 months ago

K1ngjulien commented 3 months ago

no more deprecation warnings on my machine :)

see: #2159

K1ngjulien commented 3 months ago

ah damn i'm not sure this is backwards compatible with gnome 45. no clue how to do that :sweat_smile:

K1ngjulien commented 3 months ago

its just JavaScript right? can i just check if scrollView.hadjustment === undefined and then fall back to the old way of accessing it?

or is there a better way of doing things? (sorry, I'm pretty new to writing gnome extensions)

K1ngjulien commented 3 months ago

@vanvugt @sergio-costas i think that should do it now?

vanvugt commented 3 months ago

Checks failed:

/home/runner/work/dash-to-dock/dash-to-dock/dash.js
  1142:60  error  Block must not be padded by blank lines  padded-blocks
  1147:80  error  Missing semicolon                        semi
  1148:80  error  Missing semicolon                        semi
K1ngjulien commented 3 months ago

should be fixed now

vanvugt commented 3 months ago

Thanks.

sergio-costas commented 3 months ago

Thanks!!!!

K1ngjulien commented 3 months ago

you're welcome :) sooo ready for gnome 46 release now? :P

Aqua1ung commented 3 months ago

sooo ready for gnome 46 release now? :P

C'mon guys, put it up there already!