search

micheleg / dash-to-dock

A dock for the Gnome Shell. This extension moves the dash out of the overview transforming it in a dock for an easier launching of applications and a faster switching between windows and desktops.
https://micheleg.github.io/dash-to-dock/
GNU General Public License v2.0
3.86k stars 461 forks source link

Fix communication with DING (same patch for "ubuntu-dock" branch) #2221

Closed sergio-costas closed 3 months ago

sergio-costas commented 4 months ago

This patch is the same patch from master, but for merging in "ubuntu-dock"

The extension state naming has changed from gnome shell 45 to gnome shell 46, so the code to notify margins to DING wasn't being able to detect when an extension was active, and so it didn't prevent to put icons below the dock.

This patch fixes it.

sergio-costas commented 4 months ago

Coffee hasn't kicked in yet, sorry...

sergio-costas commented 3 months ago

@3v1n0 @vanvugt Can you review this and https://github.com/micheleg/dash-to-dock/pull/2220 when you have some spare time, please? In my opinion, this should be added for 24.04.1

vanvugt commented 3 months ago

Merged, thanks.

In my opinion, this should be added for 24.04.1

It will need an LP bug for that.

sergio-costas commented 3 months ago

@vanvugt Here it is the LP https://bugs.launchpad.net/ubuntu/+source/gnome-shell-extension-desktop-icons-ng/+bug/2068882